Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deploy Eclipse Che on a virtual Kubernetes cluster #2701

Conversation

maheshrajrp
Copy link
Contributor

@maheshrajrp maheshrajrp commented Mar 7, 2024

What does this pull request change?

Addition of Che in OIDC Unsupported Kubernetes

What issues does this pull request fix or reference?

eclipse-che/che#22845

Specify the version of the product this pull request applies to

7.82

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@maheshrajrp maheshrajrp requested review from deerskindoll and a team as code owners March 7, 2024 18:11
@maheshrajrp maheshrajrp requested a review from svor March 7, 2024 18:11
Copy link

github-actions bot commented Mar 7, 2024

⚡️ Deploying pull request preview...

Copy link

github-actions bot commented Mar 7, 2024

Click here to review and test in web IDE: Contribute

@che-bot che-bot added this to Triage in Reviews Mar 7, 2024
.vscode/settings.json Outdated Show resolved Hide resolved
Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the contribution
@tolusha could you please review?

Reviews automation moved this from Triage to Approved Mar 8, 2024
@tolusha tolusha self-requested a review March 11, 2024 07:59
@tolusha tolusha changed the title procedures: Che In Unsupported OIDC Kubernetes feat: Che In Unsupported OIDC Kubernetes Apr 3, 2024
@tolusha tolusha changed the title feat: Che In Unsupported OIDC Kubernetes feat: Deploy Eclipse Che on a virtual Kubernetes cluster Apr 3, 2024
tolusha and others added 4 commits April 9, 2024 10:38
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Installing Che on the virtual Kubernetes cluster
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tolusha
Copy link
Contributor

tolusha commented Apr 11, 2024

@maheshrajrp
Could you rebase the PR on the main brain ?

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed self-referential intro

@deerskindoll
Copy link
Contributor

Workflow is failing because of an asciidoc missing attribute issue: https://docs.asciidoctor.org/asciidoc/latest/attributes/unresolved-references/. I'll continue working on this tomorrow.

@maheshrajrp The installation guide is extremely long. Are all steps truly a part of virtual cluster installation? Can the procedure be split into multiple smaller ones? For example, keycloak installation and config seem to be a separate procedure that's a prerequisite for the virtual cluster installation itself.

…al-kubernetes-cluster.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
@maheshrajrp
Copy link
Contributor Author

hi @tolusha @deerskindoll @ibuziuk
owing too much merge conflicts while rebasing, created a new PR,
#2719

Reviews automation moved this from Approved to Done Apr 14, 2024
@maheshrajrp
Copy link
Contributor Author

Workflow is failing because of an asciidoc missing attribute issue: https://docs.asciidoctor.org/asciidoc/latest/attributes/unresolved-references/. I'll continue working on this tomorrow.

@maheshrajrp The installation guide is extremely long. Are all steps truly a part of virtual cluster installation? Can the procedure be split into multiple smaller ones? For example, keycloak installation and config seem to be a separate procedure that's a prerequisite for the virtual cluster installation itself.

agreed its long, but the majority of them are related to setting up specific to vClusters, it would hard to partition, it's similar to setting up "Che in Azure" long yes, but needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Reviews
  
Done
4 participants