New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deploy Eclipse Che on a virtual Kubernetes cluster #2719
base: main
Are you sure you want to change the base?
Conversation
⚡️ Deploying pull request preview... |
@tolusha @deerskindoll @ibuziuk reopened PR with the latest changes. |
@deerskindoll this is a question for @maheshrajrp. |
hi @tolusha in any case, do you have thoughts or suggestions @tolusha @deerskindoll ? |
I'm worried about the readability and clarity of the process. It's really long and involves many components that go beyond the process of installation. I'd prefer to shift keyclok setup to a separate process and add it as a prerequisite to the installation itself. Let me check with another writer for a second opinion. @maheshrajrp I need you to include the fix for the missing attribute issue, the build and verify PR workflow won't passs otherwise. There's also a potential issue with the usage of |
@deerskindoll can you give some hints on what you mean by attributes issues or point me to some documentation? it would really help.. first-time contributor here, sorry and thanks !! |
No worries. I left the suggestion in your original PR. You need to add a backslash |
There are two more issues with the code blocks:
Can you please fix these issues? |
@deerskindoll . Thanks for the hints. I can understand. Will fix those issues. Give me a day or two (as right now I am in the middle of a career crisis), I'll pick it up and complete it asap. |
Take you time, there's no pressure here. |
Hello @maheshrajrp |
What does this pull request change?
Addition of Support for Che with vCluster
What issues does this pull request fix or reference?
eclipse-che/che#22845
Specify the version of the product this pull request applies to
7.82
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modified
step reports no vale warnings.