-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
che #9062: Adding info about env var for setting workspace pod termination grace period for Kubernetes / OpenShift infrastructures #376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other LGTM
@@ -66,4 +66,11 @@ When Eclipse Che gets deployed to Kubernetes, a PVC `che-data-volume` is [create | |||
* `kubectl describe pvc che-data-claim`, find PV it is bound to, then `oc describe pv $pvName`, you will get a local path with logs directory. Be careful with permissions for that directory, since once changed, Che server wont be able to write to a file | |||
* in Kubernetes web console, eclipse-che namespace, **pods > che-pod > logs**. | |||
|
|||
## Che Workspace Termination Grace Period | |||
|
|||
Grace termination period of Kubernetes / OpenShift workspace's pods defaults '0', which allows to terminate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a note that user-defined termination period will be used if it is specified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. lemme update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please add the same information to che.properties file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, that's the plan ;-)
…ation grace period for Kubernetes / OpenShift infrastructures Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
@sleshchenko have added info about |
Doc PR for eclipse-che/che#9118