Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

che #9062: Adding info about env var for setting workspace pod termination grace period for Kubernetes / OpenShift infrastructures #376

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Mar 20, 2018

Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other LGTM

@@ -66,4 +66,11 @@ When Eclipse Che gets deployed to Kubernetes, a PVC `che-data-volume` is [create
* `kubectl describe pvc che-data-claim`, find PV it is bound to, then `oc describe pv $pvName`, you will get a local path with logs directory. Be careful with permissions for that directory, since once changed, Che server wont be able to write to a file
* in Kubernetes web console, eclipse-che namespace, **pods > che-pod > logs**.

## Che Workspace Termination Grace Period

Grace termination period of Kubernetes / OpenShift workspace's pods defaults '0', which allows to terminate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a note that user-defined termination period will be used if it is specified.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. lemme update

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please add the same information to che.properties file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, that's the plan ;-)

…ation grace period for Kubernetes / OpenShift infrastructures

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 20, 2018

@sleshchenko have added info about user-defined termination period in both doc and property file

@ibuziuk ibuziuk merged commit b9e5b89 into eclipse-che:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants