Create new channel to install Eclipse Che next in AllNamespaces mode with DWO dependency #1079
Conversation
flacatus
requested review from
AndrienkoAleksandr,
mmorhun,
nickboldt and
tolusha
as code owners
…s mode with DWO dependency Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Makefile
Outdated
| yq -riY ".metadata.annotations[\"alm-examples\"] = \"$${CSV_CR_SAMPLES}\"" $${NEW_CSV} | ||
|
|
||
| # Set next-all-namespaces channel name | ||
| ANNOTATION_METADATA_YAML="$${NEXT_BUNDLE_PATH}/metadata/annotations.yaml" |
There was a problem hiding this comment.
I thought operator-sdk should set it to next-all-namespace
There was a problem hiding this comment.
no, by default we have next.
There was a problem hiding this comment.
But why? Where does it come from?
There was a problem hiding this comment.
https://github.com/eclipse-che/che-operator/blob/main/Makefile#L26
Comes from here. We can left as it and when all-namespaces will be by default just change there the default channel
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: flacatus, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test v7-stable-to-nightly |
|
/retest |
1 similar comment
|
/retest |
Codecov Report
@@ Coverage Diff @@
## main #1079 +/- ##
=======================================
Coverage 53.21% 53.21%
=======================================
Files 63 63
Lines 7983 7983
=======================================
Hits 4248 4248
Misses 3288 3288
Partials 447 447 Continue to review full report at Codecov.
|
Signed-off-by: Flavius Lacatusu flacatus@redhat.com
What does this PR do?
Create a new channel(next-all-namespaces) to deploy Eclipse Che next versions using OLM
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#20455
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.