Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate plugin registry URL to plugin registry configmap #1118

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Oct 1, 2021

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Add CHE_PLUGIN_REGISTRY_URL environment variable into plugin registry container and configmap

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#20547

How to test this PR?

  1. Deploy Eclipse Che
  2. Check plugin registry environment, it should contain CHE_PLUGIN_REGISTRY_URL

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci
Copy link

openshift-ci bot commented Oct 1, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 1, 2021

New changes are detected. LGTM label has been removed.

@tolusha
Copy link
Contributor

tolusha commented Oct 1, 2021

/retest

@tolusha
Copy link
Contributor

tolusha commented Oct 1, 2021

/test v7-devworkspace-happy-path

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #1118 (9853533) into main (89055c9) will increase coverage by 0.18%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1118      +/-   ##
==========================================
+ Coverage   54.33%   54.51%   +0.18%     
==========================================
  Files          67       67              
  Lines        8402     8398       -4     
==========================================
+ Hits         4565     4578      +13     
+ Misses       3365     3346      -19     
- Partials      472      474       +2     
Impacted Files Coverage Δ
pkg/deploy/pluginregistry/pluginregistry.go 69.69% <33.33%> (+7.72%) ⬆️
.../deploy/pluginregistry/pluginregistry_configmap.go 69.23% <100.00%> (+69.23%) ⬆️
controllers/che/checluster_controller.go 20.90% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89055c9...9853533. Read the comment docs.

@mmorhun mmorhun merged commit 3952a53 into main Oct 1, 2021
@mmorhun mmorhun deleted the che-20547 branch October 1, 2021 16:35
@che-bot che-bot added this to the 7.38 milestone Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants