Option to enable che-server metrics endpoint #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparkoo
requested review from
davidfestal,
l0rd,
nickboldt,
rhopp and
vparfonov
as code owners
|
|
|
This pr is related to the discussion in eclipse-che/che#15136. Please do not merge until we have some agreement. |
sparkoo
changed the title
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com> change cheMetrics to metrics.enable, remove metrics port, move che service creation to deploy package Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
# Conflicts: # pkg/deploy/che_configmap.go
sparkoo
changed the title
sparkoo
requested review from
metlos,
mshaposhnik,
skabashnyuk and
sleshchenko
This reverts commit 4a588a5.
skabashnyuk
approved these changes
Nov 28, 2019
metlos
approved these changes
Nov 28, 2019
pkg/deploy/che_service_test.go
Outdated
| t.Error("expected 2 ports") | ||
| } | ||
| checkPort(ports[0], "http", 8080, t) | ||
| checkPort(ports[1], "metrics", 8087, t) |
There was a problem hiding this comment.
DefaultCheMetricsPort instead of 8087?
There was a problem hiding this comment.
yes, I've also changed type from string to int32 to avoid conversions.
Signed-off-by: Michal Vala <mvala@redhat.com>
nickboldt
pushed a commit
to nickboldt/che-operator
that referenced
this pull request
Jan 31, 2020
Signed-off-by: Michal Vala <mvala@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In eclipse-che/che#15046 and it's subtask eclipse-che/che#15137, we're going to implement way to deploy monitoring stack with che-operator. This PR is adding first step, to be able to enable metrics endpoint on server with che CR.
fixes eclipse-che/che#15210