Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove obsolete code after switching to Dev Workspace enabled #1291

Merged
merged 15 commits into from
Jan 24, 2022

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jan 17, 2022

@openshift-ci
Copy link

openshift-ci bot commented Jan 17, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha
Copy link
Contributor Author

tolusha commented Jan 17, 2022

ci/prow/v9-devworkspace-happy-path

@tolusha
Copy link
Contributor Author

tolusha commented Jan 17, 2022

/retest

@tolusha tolusha changed the title chore: Remove keycloak deployment chore: Remove obsolete code related to che-server engine Jan 17, 2022
@tolusha tolusha changed the title chore: Remove obsolete code related to che-server engine chore: Remove obsolete code after switching to Dev Workspace enabled Jan 18, 2022
@tolusha
Copy link
Contributor Author

tolusha commented Jan 18, 2022

/retest

1 similar comment
@tolusha
Copy link
Contributor Author

tolusha commented Jan 19, 2022

/retest

@tolusha tolusha force-pushed the 20982 branch 2 times, most recently from 5e75db0 to e76a734 Compare January 19, 2022 14:58
@tolusha
Copy link
Contributor Author

tolusha commented Jan 20, 2022

/retest

@musienko-maxim
Copy link
Contributor

/test v9-devworkspace-happy-path

@tolusha
Copy link
Contributor Author

tolusha commented Jan 20, 2022

/retest

@musienko-maxim
Copy link
Contributor

/test v9-devworkspace-happy-path

@tolusha
Copy link
Contributor Author

tolusha commented Jan 20, 2022

/retest

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
…CNames fields

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
…field

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Copy link
Contributor Author

tolusha commented Jan 21, 2022

/retest

@tolusha
Copy link
Contributor Author

tolusha commented Jan 21, 2022

/test v9-devworkspace-happy-path

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #1291 (4ee944c) into main (228a335) will increase coverage by 3.55%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1291      +/-   ##
==========================================
+ Coverage   56.19%   59.75%   +3.55%     
==========================================
  Files          84       78       -6     
  Lines        7946     6353    -1593     
==========================================
- Hits         4465     3796     -669     
+ Misses       2995     2180     -815     
+ Partials      486      377     -109     
Impacted Files Coverage Δ
controllers/che/checluster_controller.go 0.00% <ø> (-34.36%) ⬇️
controllers/che/checluster_validator.go 0.00% <0.00%> (ø)
pkg/deploy/consolelink/consolelink.go 71.73% <ø> (+4.39%) ⬆️
pkg/deploy/dev-workspace/dev_workspace.go 56.25% <ø> (+2.25%) ⬆️
.../identity-provider/identity_provider_reconciler.go 0.00% <0.00%> (-9.06%) ⬇️
...deploy/identity-provider/identity_provider_util.go 0.00% <ø> (ø)
pkg/deploy/postgres/postgres.go 32.65% <ø> (+12.17%) ⬆️
pkg/deploy/rbac/gateway_permissions.go 0.00% <0.00%> (ø)
pkg/deploy/server/default_values_reconciler.go 0.00% <ø> (-45.40%) ⬇️
pkg/deploy/server/server_util.go 64.28% <ø> (+5.46%) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 228a335...4ee944c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants