Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor Kubernetes Image Puller #1598

Merged
merged 2 commits into from
Jan 12, 2023
Merged

chore: Refactor Kubernetes Image Puller #1598

merged 2 commits into from
Jan 12, 2023

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jan 11, 2023

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

chore: Refactor Kubernetes Image Puller

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#21900

How to test this PR?

  1. Deploy Eclipse Che by running chectl server:deploy -p minikube --che-operator-image=quay.io/abazko/operator:21900
  2. Deploy Kubernetes Image Puller operator by running make deploy from https://github.com/che-incubator/kubernetes-image-puller-operator
  3. Enable Kubernetes Image Puller in CheCluster
  4. Check that KubernetesImagePuller CR eclipse-che-image-puller is created

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Jan 11, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Copy link
Contributor Author

tolusha commented Jan 12, 2023

/test v11-operator-test

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #1598 (bb78deb) into main (c0e1de8) will decrease coverage by 0.18%.
The diff coverage is 65.00%.

@@            Coverage Diff             @@
##             main    #1598      +/-   ##
==========================================
- Coverage   58.95%   58.76%   -0.19%     
==========================================
  Files          73       73              
  Lines        8614     8447     -167     
==========================================
- Hits         5078     4964     -114     
+ Misses       3190     3152      -38     
+ Partials      346      331      -15     
Impacted Files Coverage Δ
pkg/deploy/image-puller/imagepuller.go 74.54% <65.00%> (+3.78%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tolusha tolusha merged commit 4e75590 into main Jan 12, 2023
@tolusha tolusha deleted the 21900 branch January 12, 2023 10:25
@devstudio-release
Copy link

Build 3.5 :: operator_3.x/171: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@che-bot che-bot added this to the 7.60 milestone Jan 12, 2023
@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.5 :: push-latest-container-to-quay_3.x/1517: SUCCESS

Copied: devspaces-rhel8-operator; /job/DS_CI/job/update-digests_3.x triggered;
/job/DS_CI/job/Releng/job/copyIIBsToQuay triggered for OCP v4.12 v4.11 v4.10

@devstudio-release
Copy link

Build 3.5 :: update-digests_3.x/1848: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.5 :: copyIIBsToQuay/660: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.5 :: sync-to-downstream_3.x/1971: SUCCESS

Build container: devspaces-operator synced; /DS_CI/get-sources-rhpkg-container-build_3.x/1899 triggered;

@devstudio-release
Copy link

Build 3.5 :: operator_3.x/171: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/1971 triggered

@devstudio-release
Copy link

Build 3.5 :: operator-bundle_3.x/766: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.5 :: copyIIBsToQuay/661: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.5 :: push-latest-container-to-quay_3.x/1518: SUCCESS

Copied: devspaces-operator-bundle; bundle-generated updated;
/job/DS_CI/job/Releng/job/copyIIBsToQuay triggered for OCP v4.12 v4.11 v4.10

@devstudio-release
Copy link

Build 3.5 :: copyIIBsToQuay/660: SUCCESS

arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.5-59
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.5-60
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.18-2
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.5-v4.12-411811-410106-ppc64le
  + quay.io/devspaces/iib:3.5-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le
  + quay.io/devspaces/iib:3.5-v4.11-411798-410097-ppc64le
  + quay.io/devspaces/iib:3.5-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le
  + quay.io/devspaces/iib:3.5-v4.10-412375-410093-ppc64le
  + quay.io/devspaces/iib:3.5-v4.10-ppc64le
  + quay.io/devspaces/iib:next-v4.10-ppc64le
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.5-v4.12-411811-410106-s390x
  + quay.io/devspaces/iib:3.5-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
  + quay.io/devspaces/iib:3.5-v4.11-411798-410097-s390x
  + quay.io/devspaces/iib:3.5-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
  + quay.io/devspaces/iib:3.5-v4.10-412375-410093-s390x
  + quay.io/devspaces/iib:3.5-v4.10-s390x
  + quay.io/devspaces/iib:next-v4.10-s390x
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.5-v4.12-411811-410106-x86_64
  + quay.io/devspaces/iib:3.5-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
  + quay.io/devspaces/iib:3.5-v4.11-411798-410097-x86_64
  + quay.io/devspaces/iib:3.5-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
  + quay.io/devspaces/iib:3.5-v4.10-412375-410093-x86_64
  + quay.io/devspaces/iib:3.5-v4.10-x86_64
  + quay.io/devspaces/iib:next-v4.10-x86_64

@devstudio-release
Copy link

Build 3.5 :: sync-to-downstream_3.x/1972: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/1900 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.5 :: operator-bundle_3.x/766: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/1972 triggered

@devstudio-release
Copy link

Build 3.5 :: dsc_3.x/561: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.5 :: update-digests_3.x/1848: SUCCESS

Detected new images: rebuild operator-bundle
* devspaces-operator; /DS_CI/operator-bundle_3.x/766 triggered

@devstudio-release
Copy link

Build 3.5 :: dsc_3.x/561: SUCCESS

3.5.0 CI

@devstudio-release
Copy link

Build 3.5 :: copyIIBsToQuay/661: SUCCESS

arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.5-60
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.18-2
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.5-v4.12-412388-410106-ppc64le
  + quay.io/devspaces/iib:3.5-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le
  + quay.io/devspaces/iib:3.5-v4.11-412379-410097-ppc64le
  + quay.io/devspaces/iib:3.5-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le
  + quay.io/devspaces/iib:3.5-v4.10-412375-410093-ppc64le
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.5-v4.12-412388-410106-x86_64
  + quay.io/devspaces/iib:3.5-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
  + quay.io/devspaces/iib:3.5-v4.11-412379-410097-x86_64
  + quay.io/devspaces/iib:3.5-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
  + quay.io/devspaces/iib:3.5-v4.10-412375-410093-x86_64
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.5-v4.12-412388-410106-s390x
  + quay.io/devspaces/iib:3.5-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
  + quay.io/devspaces/iib:3.5-v4.11-412379-410097-s390x
  + quay.io/devspaces/iib:3.5-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
  + quay.io/devspaces/iib:3.5-v4.10-412375-410093-s390x

@devstudio-release
Copy link

Build 3.5 :: operator-bundle_3.x/767: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.5 :: copyIIBsToQuay/664: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.5 :: push-latest-container-to-quay_3.x/1521: SUCCESS

Copied: devspaces-operator-bundle; bundle-generated updated;
/job/DS_CI/job/Releng/job/copyIIBsToQuay triggered for OCP v4.12 v4.11 v4.10

@devstudio-release
Copy link

Build 3.5 :: sync-to-downstream_3.x/1979: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/1907 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.5 :: operator-bundle_3.x/767: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/1979 triggered

@devstudio-release
Copy link

Build 3.5 :: dsc_3.x/562: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.5 :: dsc_3.x/562: SUCCESS

3.5.0 CI

@devstudio-release
Copy link

Build 3.5 :: copyIIBsToQuay/664: SUCCESS

arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.5-61
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.18-2
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.5-v4.12-413019-410106-s390x
  + quay.io/devspaces/iib:3.5-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
  + quay.io/devspaces/iib:3.5-v4.11-413013-410097-s390x
  + quay.io/devspaces/iib:3.5-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
  + quay.io/devspaces/iib:3.5-v4.10-413008-410093-s390x
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.5-v4.12-413019-410106-ppc64le
  + quay.io/devspaces/iib:3.5-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le
  + quay.io/devspaces/iib:3.5-v4.11-413013-410097-ppc64le
  + quay.io/devspaces/iib:3.5-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le
  + quay.io/devspaces/iib:3.5-v4.10-413008-410093-ppc64le
  + quay.io/devspaces/iib:3.5-v4.10-ppc64le
  + quay.io/devspaces/iib:next-v4.10-ppc64le
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.5-v4.12-413019-410106-x86_64
  + quay.io/devspaces/iib:3.5-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
  + quay.io/devspaces/iib:3.5-v4.11-413013-410097-x86_64
  + quay.io/devspaces/iib:3.5-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
  + quay.io/devspaces/iib:3.5-v4.10-413008-410093-x86_64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants