-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support devWorkspace.ignoredUnrecoverableEvents
.
#1864
Support devWorkspace.ignoredUnrecoverableEvents
.
#1864
Conversation
Skipping CI for Draft Pull Request. |
f820abd
to
c62ac10
Compare
/cc @dkwon17 |
Hello @monaka, thank you for the PR, could you please rebase and rerun |
api/v2/checluster_types.go
Outdated
@@ -189,6 +189,13 @@ type CheClusterDevEnvironments struct { | |||
// +optional | |||
// +kubebuilder:validation:Enum=Always;IfNotPresent;Never | |||
ImagePullPolicy corev1.PullPolicy `json:"imagePullPolicy,omitempty"` | |||
// IgnoredUnrecoverableEvents defines a list of Kubernetes event names that should | |||
// be ignored when deciding to fail a DevWorkspace startup. This option should be used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be mistaken, but I think we just refer to workspaces instead of DevWorkspaces from a Che perspective? i.e. when deciding to fail a DevWorkspace startup
-> when deciding to fail a workspace that is starting
.
Same thing for Events listed here will not trigger DevWorkspace failures.
-> Events listed here will not trigger workspace failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I fixed comments as you suggested.
@@ -194,6 +196,14 @@ func updateWorkspaceImagePullPolicy(imagePullPolicy corev1.PullPolicy, workspace | |||
workspaceConfig.ImagePullPolicy = string(imagePullPolicy) | |||
} | |||
|
|||
func updateIgnoredUnrecoverableEvents(operatorConfig *controllerv1alpha1.OperatorConfiguration, ignoredUnrecoverableEvents []string) { | |||
if ignoredUnrecoverableEvents == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this nil check? Can't we just do operatorConfig.Workspace.IgnoredUnrecoverableEvents = ignoredUnrecoverableEvents
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I removed the nil check.
d8a134d
to
3b37782
Compare
eb12927
to
f605695
Compare
f605695
to
77f709b
Compare
77f709b
to
925feed
Compare
/test v14-devworkspace-happy-path |
Build 3.16 :: sync-to-downstream_3.x/7060: Console, Changes, Git Data |
Build 3.16 :: get-sources-rhpkg-container-build_3.x/7038: devspaces-operator-bundle : 3.x :: Failed in 62378966 : BREW:BUILD/STATUS:UNKNOWN |
Build 3.16 :: operator-bundle_3.x/3182: Console, Changes, Git Data |
Build 3.16 :: sync-to-downstream_3.x/7061: Console, Changes, Git Data |
Build 3.16 :: get-sources-rhpkg-container-build_3.x/7039: devspaces-operator-bundle : 3.x :: Failed in 62379453 : BREW:BUILD/STATUS:UNKNOWN |
Build 3.16 :: operator-bundle_3.x/3184: Console, Changes, Git Data |
Build 3.16 :: sync-to-downstream_3.x/7064: Console, Changes, Git Data |
Build 3.16 :: get-sources-rhpkg-container-build_3.x/7042: devspaces-operator-bundle : 3.x :: Failed in 62381553 : BREW:BUILD/STATUS:UNKNOWN |
Build 3.16 :: operator-bundle_3.x/3185: Console, Changes, Git Data |
Build 3.16 :: sync-to-downstream_3.x/7066: Console, Changes, Git Data |
Build 3.16 :: get-sources-rhpkg-container-build_3.x/7044: devspaces-operator-bundle : 3.x :: Failed in 62382559 : BREW:BUILD/STATUS:UNKNOWN |
Build 3.16 :: operator-bundle_3.x/3186: Console, Changes, Git Data |
Build 3.16 :: sync-to-downstream_3.x/7067: Console, Changes, Git Data |
Build 3.16 :: get-sources-rhpkg-container-build_3.x/7045: devspaces-operator-bundle : 3.x :: Failed in 62382628 : BREW:BUILD/STATUS:UNKNOWN |
Build 3.16 :: operator-bundle_3.x/3187: Console, Changes, Git Data |
Build 3.16 :: sync-to-downstream_3.x/7068: Console, Changes, Git Data |
Build 3.16 :: get-sources-rhpkg-container-build_3.x/7046: devspaces-operator-bundle : 3.x :: Failed in 62385338 : BREW:BUILD/STATUS:UNKNOWN |
Build 3.16 :: operator-bundle_3.x/3188: Console, Changes, Git Data |
Build 3.16 :: sync-to-downstream_3.x/7069: Console, Changes, Git Data |
Build 3.16 :: get-sources-rhpkg-container-build_3.x/7047: devspaces-operator-bundle : 3.x :: Failed in 62388162 : BREW:BUILD/STATUS:UNKNOWN |
@monaka thank you for the contribution, new feature is part of the RN - https://twitter.com/eclipse_che/status/1816081779607928954 |
What does this PR do?
Adds
devWorkspace.ignoredUnrecoverdableEvents
to CheCluster CR.Che workspaces will become to run on clusters with a node autoscaler like Cluster Autoscaler, Karpenter .
Screenshot/screencast of this PR
The workspace pod is waiting for a new node by cluster autoscaler.
What issues does this PR fix or reference?
eclipse-che/che#22598
How to test this PR?
OpenShift
on Minikube
But I suppose this PR is hard to test on Minikube as it won't have any cluster autoscaler.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.