Set default Che secret name in Che server config map if tlsSecretName is not specified in CR #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is not specified in CR Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
mmorhun
requested review from
benoitf,
davidfestal,
tolusha,
sleshchenko and
AndrienkoAleksandr
mmorhun
requested review from
l0rd,
nickboldt,
rhopp and
vparfonov
as code owners
tolusha
approved these changes
Mar 13, 2020
|
[test] |
AndrienkoAleksandr
approved these changes
Mar 13, 2020
tolusha
reviewed
Mar 13, 2020
| @@ -128,6 +128,9 @@ func GetConfigMapData(cr *orgv1.CheCluster) (cheEnv map[string]string) { | |||
|
|
|||
| ingressDomain := cr.Spec.K8s.IngressDomain | |||
| tlsSecretName := cr.Spec.K8s.TlsSecretName | |||
| if tlsSupport && tlsSecretName == "" { | |||
There was a problem hiding this comment.
What is the benefit of len(tlsSecretName) < 1 over tlsSecretName == ""?
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Morhun mmorhun@redhat.com
What does this PR do?
Sets default Che TLS secret name in Che config map if Che CR doesn't specify it when TLS is turned on.
Referenced issues
eclipse-che/che#16280