Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't set probes when debug=true #399

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

sparkoo
Copy link
Member

@sparkoo sparkoo commented Aug 13, 2020

Signed-off-by: Michal Vala mvala@redhat.com

eclipse-che/che#17581

Signed-off-by: Michal Vala <mvala@redhat.com>
@sparkoo
Copy link
Member Author

sparkoo commented Aug 13, 2020

/retest

@tolusha
Copy link
Contributor

tolusha commented Aug 13, 2020

[test]

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorhun, sparkoo, tolusha
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha
Copy link
Contributor

tolusha commented Aug 13, 2020

/test v5-che-operator-olm-latest-changes-tests

@tolusha
Copy link
Contributor

tolusha commented Aug 13, 2020

[MINIKUBE] Testing latest changes using OLM is broken due to

error: unable to read URL "https://raw.githubusercontent.com/operator-framework/operator-marketplace/master/deploy/upstream/03_operatorsource.crd.yaml", server reported 404 Not Found, status code=404

@openshift-ci-robot
Copy link

@sparkoo: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v5-che-operator-olm-latest-changes-tests 918b9d8 link /test v5-che-operator-olm-latest-changes-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tolusha
Copy link
Contributor

tolusha commented Aug 13, 2020

Testing the latest changes using olm on minikube is fixed by #400
I've locally checked the latest changes using olm on OpenShift and everything worked fine.

@tolusha
Copy link
Contributor

tolusha commented Aug 13, 2020

@sparkoo
You can merge the PR

@sparkoo sparkoo merged commit 6117383 into eclipse-che:master Aug 13, 2020
@sparkoo sparkoo deleted the gh17581-debugProbe branch August 13, 2020 12:31
@che-bot che-bot added this to the 7.18 milestone Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants