Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value to {} for singleHostGatewayConfigMapLabels #447

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Sep 17, 2020

Signed-off-by: Anatolii Bazko abazko@redhat.com

Reference issue

eclipse-che/che#17888

What does this PR do

Since spec.server.singleHostGatewayConfigMapLabel is type of labels.Set the default value should be set to {} instead of ""

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 17, 2020

@tolusha: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v5-che-operator-olm-latest-changes-tests 559481d link /test v5-che-operator-olm-latest-changes-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sparkoo, tolusha
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flacatus
Copy link
Contributor

/retest

@tolusha tolusha merged commit ec867e2 into master Sep 17, 2020
@tolusha tolusha deleted the fixcryaml branch September 17, 2020 08:04
@che-bot che-bot added this to the 7.19 milestone Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants