Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate jobs from ci.centos to GH actions #451

Merged
merged 14 commits into from
Sep 24, 2020
Merged

Migrate jobs from ci.centos to GH actions #451

merged 14 commits into from
Sep 24, 2020

Conversation

flacatus
Copy link
Contributor

Signed-off-by: Flavius Lacatusu flacatus@redhat.com

@flacatus
Migrate jobs from ci.centos to GH actions
b993129 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
Copy link
Contributor Author

@AndrienkoAleksandr I change Check nightly "opm" bundle / Check nightly "opm" bundle (pull_request) to run only in PR.

@flacatus
Copy link
Contributor Author

CI CENTOS jobs should fail in this PR after new changes in CI. After merge this PR centos ci jobs will be deleted

@AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr I change Check nightly "opm" bundle / Check nightly "opm" bundle (pull_request) to run only in PR.

Great

@flacatus
Copy link
Contributor Author

/retest

@flacatus
Fixes
a4fe033 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@tolusha tolusha mentioned this pull request Sep 21, 2020
Closed
48 tasks
@flacatus flacatus changed the title [NOT READY FOR REVIEW]Migrate jobs from ci.centos to GH actions Migrate jobs from ci.centos to GH actions Sep 21, 2020
@tolusha
Copy link
Contributor

tolusha commented Sep 22, 2020 •
edited
Loading

Che Operator Updates / Minikube

Testing stable versions updates / Minikube

Che Operator Updates / Minishift update

Testing stable versions updates / Minishift

Che Operator che nightly / Minishift

Testing latest changes / Minishift

Che Operator olm / Minikube olm changes

Testing latest changes with olm / Minikube

Che Operator e2e tests / Minishift e2e

Che Operator e2e tests / Minishift

@tolusha
Copy link
Contributor

tolusha commented Sep 22, 2020

Could you check ci/prow/v5-che-operator-olm-latest-changes-tests this jobs fails ?

@flacatus
Copy link
Contributor Author

/test v5-che-operator-olm-latest-changes-tests

flacatus
flacatus commented Sep 22, 2020
View reviewed changes
Copy link
Contributor Author

@flacatus flacatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndrienkoAleksandr my mistake

@flacatus
Fix openshift tests and rename actions name
7c5ed74 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
Copy link
Contributor Author

Pending to add some secrets and add tests logs to github actions artificats

@tolusha
Copy link
Contributor

tolusha commented Sep 22, 2020

Without digging into details, for the latest changes tests we have to use not the nightly version of the operator but the operator built from the PR. Do we follow this way?

@flacatus
Add artifacts with job results to actions
4b3e680 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
Copy link
Contributor Author

Finished the part to add all logs in GH artifacts:
Example: https://github.com/eclipse/che-operator/actions/runs/266861040

@flacatus
Build operator image in nightly tests
ef701eb 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
Add github_token secret
56884fa 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
Fixes
555fa66 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
Fixes
0746cce 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
Fix artifacts
0144907 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
Copy link
Contributor Author

@tolusha @AndrienkoAleksandr What do you think about adding shell check to the operator PRs? Like here: https://github.com/eclipse/che-plugin-registry/blob/master/.github/workflows/shellcheck-pr-check.yml

@AndrienkoAleksandr
Copy link
Contributor

@tolusha @AndrienkoAleksandr What do you think about adding shell check to the operator PRs? Like here:

+1, but it would be nice to do that in the next pr, because maybe you need to change a lot of 'bad' code to make this check working. It would prefer avoid mixing CI migration changes and shellcheck improvements.

@flacatus
Implement suggestions
5f68b45 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
Copy link
Contributor Author

/retest

@flacatus
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, flacatus, tolusha
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flacatus flacatus merged commit e00bc3e into eclipse-che:master Sep 24, 2020
@che-bot che-bot added this to the 7.20 milestone Sep 24, 2020
mkuznyetsov pushed a commit that referenced this pull request Sep 25, 2020
@flacatus @mkuznyetsov
Merge pull request #451 from flacatus/migreate_tests
0ea109c 
Migrate jobs from ci.centos to GH actions
mkuznyetsov added a commit that referenced this pull request Sep 25, 2020
@che-bot @mkuznyetsov @flacatus
Release version 7.19.1 (#472)
a4e4017 
* Update defaults tags to 7.19.1

Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>

* Release OLM files to 7.19.1

Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>

* Merge pull request #451 from flacatus/migreate_tests

Migrate jobs from ci.centos to GH actions

Co-authored-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
Co-authored-by: Flavius Lacatusu <flacatus@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolusha tolusha tolusha approved these changes

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@davidfestal davidfestal Awaiting requested review from davidfestal

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees

@tolusha tolusha

@AndrienkoAleksandr AndrienkoAleksandr

Labels
lgtm
Projects
None yet
Milestone
7.20
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@flacatus @AndrienkoAleksandr @tolusha @openshift-ci-robot @che-bot