-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate jobs from ci.centos to GH actions #451
Conversation
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@AndrienkoAleksandr I change |
CI CENTOS jobs should fail in this PR after new changes in CI. After merge this PR centos ci jobs will be deleted |
Great |
/retest |
Testing stable versions updates / Minikube
Testing stable versions updates / Minishift
Testing latest changes / Minishift
Testing latest changes with olm / Minikube
Che Operator e2e tests / Minishift |
Could you check |
/test v5-che-operator-olm-latest-changes-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndrienkoAleksandr my mistake
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Pending to add some secrets and add tests logs to github actions artificats |
Without digging into details, for the latest changes tests we have to use not the nightly version of the operator but the operator built from the PR. Do we follow this way? |
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Finished the part to add all logs in GH artifacts: |
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@tolusha @AndrienkoAleksandr What do you think about adding shell check to the operator PRs? Like here: https://github.com/eclipse/che-plugin-registry/blob/master/.github/workflows/shellcheck-pr-check.yml |
+1, but it would be nice to do that in the next pr, because maybe you need to change a lot of 'bad' code to make this check working. It would prefer avoid mixing CI migration changes and shellcheck improvements. |
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
/retest |
/retest |
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, flacatus, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Migrate jobs from ci.centos to GH actions
* Update defaults tags to 7.19.1 Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com> * Release OLM files to 7.19.1 Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com> * Merge pull request #451 from flacatus/migreate_tests Migrate jobs from ci.centos to GH actions Co-authored-by: Mykhailo Kuznietsov <mkuznets@redhat.com> Co-authored-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu flacatus@redhat.com