Remove consolelink object when CheCluster is removed #708
Conversation
|
Skipping CI for Draft Pull Request. |
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
==========================================
+ Coverage 33.11% 34.22% +1.10%
==========================================
Files 50 52 +2
Lines 5499 5537 +38
==========================================
+ Hits 1821 1895 +74
+ Misses 3407 3366 -41
- Partials 271 276 +5
Continue to review full report at Codecov.
|
tolusha
requested review from
AndrienkoAleksandr,
flacatus,
mmorhun and
nickboldt
as code owners
|
/retest |
|
@tolusha: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
==========================================
+ Coverage 33.11% 35.54% +2.42%
==========================================
Files 50 52 +2
Lines 5499 5517 +18
==========================================
+ Hits 1821 1961 +140
+ Misses 3407 3276 -131
- Partials 271 280 +9
Continue to review full report at Codecov.
|
pkg/deploy/sync.go
Outdated
| func Update(deployContext *DeployContext, actual runtime.Object, blueprint metav1.Object, diffOpts cmp.Option) (bool, error) { | ||
| client := getClientForObject(blueprint, deployContext) | ||
| actualMeta := actual.(metav1.Object) |
There was a problem hiding this comment.
Should we check object casting here?
pkg/controller/che/che_controller.go
Outdated
| @@ -137,7 +136,7 @@ func add(mgr manager.Manager, r reconcile.Reconciler) error { | |||
| if err := corev1.AddToScheme(mgr.GetScheme()); err != nil { | |||
| logrus.Errorf("Failed to add OpenShift Core to scheme: %s", err) | |||
| } | |||
| if hasConsolelinkObject() { | |||
| if util.HasAPIResourceName("consolelinks") { | |||
There was a problem hiding this comment.
Maybe console links should be const?
|
/retest |
|
/test v7-single-host-nightly-deployment |
|
/retest |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, flacatus, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
Remove consolelink object when CheCluster is removed
What issues does this PR fix or reference?
eclipse-che/che#18501
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.