Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include additional cluster-wide trusted CA into Che #718

Merged
merged 3 commits into from
Mar 18, 2021
Merged

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Mar 15, 2021

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Includes CA certificates configured in proxy/cluster into list of trusted by Che certificates even if no proxy configuration added.

What issues does this PR fix or reference?

eclipse-che/che#17938

How to test this PR?

  1. Configure Openshift router with a custom certificate chain
  2. Add all the CA certificates from the chain into proxy/cluster (excluding server one).
  3. Deploy Che using operator from this branch
  4. Start a workspace, ensure everything works as expected

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@openshift-merge-robot
Copy link

@mmorhun: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v6-che-operator-single-host-nightly-deployment 3b3ea49 link /test v6-che-operator-single-host-nightly-deployment
ci/prow/v6-che-operator-olm-nightly-deployment 3b3ea49 link /test v6-che-operator-olm-nightly-deployment
ci/prow/v7-che-operator-olm-nightly-deployment 3b3ea49 link /test v7-che-operator-olm-nightly-deployment
ci/prow/v7-che-operator-single-host-nightly-deployment 3b3ea49 link /test v7-che-operator-single-host-nightly-deployment
ci/prow/v7-che-operator-proxy-deployment 3b3ea49 link /test v7-che-operator-proxy-deployment

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@flacatus
Copy link
Contributor

/test ?

@flacatus
Copy link
Contributor

/retest

@tolusha
Copy link
Contributor

tolusha commented Mar 16, 2021

add some tests to https://github.com/eclipse-che/che-operator/blob/master/pkg/controller/che/proxy_test.go

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
pkg/controller/che/proxy.go Outdated Show resolved Hide resolved
pkg/controller/che/proxy.go Outdated Show resolved Hide resolved
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@flacatus
Copy link
Contributor

/retest

1 similar comment
@flacatus
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorhun
Copy link
Contributor Author

mmorhun commented Mar 17, 2021

/retest

@flacatus
Copy link
Contributor

@mmorhun there are some job fixes in master

@flacatus
Copy link
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants