Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Newer operator sdk #826

Merged
merged 17 commits into from
Jul 19, 2021
Merged

feat: Newer operator sdk #826

merged 17 commits into from
Jul 19, 2021

Conversation

@openshift-ci
Copy link

openshift-ci bot commented May 9, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #826 (70fe4cf) into main (72f8d81) will decrease coverage by 0.64%.
The diff coverage is 35.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
- Coverage   46.46%   45.82%   -0.65%     
==========================================
  Files          53       55       +2     
  Lines        5324     5370      +46     
==========================================
- Hits         2474     2461      -13     
- Misses       2541     2598      +57     
- Partials      309      311       +2     
Impacted Files Coverage Δ
controllers/che_cr_validator.go 0.00% <0.00%> (ø)
controllers/permission_checker.go 0.00% <0.00%> (ø)
controllers/status.go 0.00% <0.00%> (ø)
controllers/update.go 0.00% <0.00%> (ø)
pkg/deploy/checluster.go 11.76% <ø> (ø)
pkg/deploy/defaults.go 49.33% <ø> (ø)
pkg/deploy/dev-workspace/dev_workspace.go 67.42% <ø> (ø)
...kg/deploy/identity-provider/deployment_keycloak.go 54.75% <ø> (ø)
pkg/deploy/identity-provider/exec.go 0.00% <ø> (ø)
pkg/deploy/identity-provider/identity_provider.go 12.57% <ø> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72f8d81...70fe4cf. Read the comment docs.

pkg/deploy/identity-provider/deployment_keycloak_test.go Outdated Show resolved Hide resolved
controllers/status.go Outdated Show resolved Hide resolved
controllers/update.go Outdated Show resolved Hide resolved
replace-images-tags.sh Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
config/manager/manager.yaml Outdated Show resolved Hide resolved
config/crd/bases/org_v1_che_crd-v1beta1.yaml Outdated Show resolved Hide resolved
config/manager/manager.yaml Outdated Show resolved Hide resolved
config/manager/manager.yaml Outdated Show resolved Hide resolved
@tolusha
Copy link
Contributor

tolusha commented Jul 16, 2021

Great work!

@openshift-ci
Copy link

openshift-ci bot commented Jul 16, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Jul 16, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Jul 16, 2021
…lict.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@tolusha
Copy link
Contributor

tolusha commented Jul 19, 2021

/test v7-stable-to-nightly

@openshift-ci
Copy link

openshift-ci bot commented Jul 19, 2021

@AndrienkoAleksandr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/v8-ci-index 7ea60c3 link /test v8-ci-index
ci/prow/v7-ci-index 7ea60c3 link /test v7-ci-index
ci/prow/v7-multi-host-nightly-deployment 7ea60c3 link /test v7-multi-host-nightly-deployment
ci/prow/v7-single-host-nightly-deployment 7ea60c3 link /test v7-single-host-nightly-deployment
ci/prow/v8-multi-host-nightly-deployment 7ea60c3 link /test v8-multi-host-nightly-deployment
ci/prow/v8-single-host-nightly-deployment 7ea60c3 link /test v8-single-host-nightly-deployment
ci/prow/v7-devworkspace-happy-path 7ea60c3 link /test v7-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tolusha
Copy link
Contributor

tolusha commented Jul 19, 2021

/test v7-stable-to-nightly

@tolusha
Copy link
Contributor

tolusha commented Jul 19, 2021

Minishift / Test Eclipse Che update from stable to nightly passed locally.
We are good to merge here.

@AndrienkoAleksandr AndrienkoAleksandr merged commit f555494 into main Jul 19, 2021
@AndrienkoAleksandr AndrienkoAleksandr deleted the newerOperatorSDK branch July 19, 2021 11:29
@che-bot che-bot added this to the 7.34 milestone Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants