fix: Allow roles update for che workspace cluster role #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshaposhnik
requested review from
AndrienkoAleksandr,
flacatus,
mmorhun,
nickboldt and
tolusha
as code owners
tolusha
reviewed
Jul 16, 2021
|
Sounds ok. I will update resources once #826 is merged |
|
/notest |
|
/pls stop |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
tolusha
force-pushed
the
allow_roles_update
branch
from
28d47d9
to
3b33500
Compare
tolusha
changed the title
tolusha
approved these changes
Jul 21, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mshaposhnik, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Pls. merge |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In case if Roles or RoleBindings were changed (updated/removed/added), existing workspace ServiceAccount doesn't apply such updates. To be able to update them, we need appropriate permission.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#19697
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.