Automatically chmod +x all .sh files in sidecar definitions #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents common entrypoint permission errors. Signed-off-by: Eric Williams <ericwill@redhat.com>
ericwill
requested review from
benoitf,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
benoitf
approved these changes
Nov 10, 2020
|
what about a script that check permissions on pr ? |
This way is simpler IMO |
|
it looks more workaround than ensuring consistent source code like if you want to build locally a sidecar by cloning source code |
@ericwill Happy Path PR check [build 401] failed.Re-trigger by
Depending on failure reason, the artifacts or deployment may not be present. |
|
I'll handle this in eclipse-che/che#18737 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Williams ericwill@redhat.com
What does this PR do?
Prevents common permission errors scripts in sidecar containers.
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#18217
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.