Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PR check to ensure sidecar executable files are have correct permissions #18737

Closed
ericwill opened this issue Jan 5, 2021 · 0 comments · Fixed by eclipse-che/che-plugin-registry#824
Closed

Add PR check to ensure sidecar executable files are have correct permissions #18737

ericwill opened this issue Jan 5, 2021 · 0 comments · Fixed by eclipse-che/che-plugin-registry#824
Assignees
@ericwill
Labels
area/plugin-registry kind/task Internal things, technical debt, and to-do tasks to be performed.
Milestone
7.26

Comments

@ericwill
Copy link
Contributor

ericwill commented Jan 5, 2021

Is your task related to a problem? Please describe.

Often, .sh files within sidecar definition folders will not have the correct executable permissions set, leading to errors when starting workspaces. It's hard to tell this just by looking at a PR,

Describe the solution you'd like

Introduce a PR check that validates the permissions on any .sh file included in a sidecar definition.

Describe alternatives you've considered

Additional context
@ericwill ericwill added kind/task Internal things, technical debt, and to-do tasks to be performed. area/plugin-registry labels Jan 5, 2021
@ericwill ericwill added this to the 7.x (Later, Future, Never) milestone Jan 5, 2021
@ericwill ericwill self-assigned this Jan 5, 2021
@ericwill ericwill mentioned this issue Jan 5, 2021
Closed
9 tasks
@ericwill ericwill mentioned this issue Jan 14, 2021
Closed
33 tasks
@ericwill ericwill mentioned this issue Feb 1, 2021
Merged
9 tasks
ericwill added a commit to eclipse-che/che-plugin-registry that referenced this issue Feb 2, 2021
@ericwill
Add PR check to ensure sidecar executable files are have correct perm…
7e824ab 
…issions (#824)

If a sidecar adds any .sh files, check that they are executable to prevent entrypoint errors.

Fixes eclipse-che/che#18737

Signed-off-by: Eric Williams <ericwill@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericwill ericwill

Labels
area/plugin-registry kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
7.26
Development

Successfully merging a pull request may close this issue.

Add a PR check to ensure that sidecar executable files have executable permissions
1 participant
@ericwill