Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workspace storage volume mount for che-theia editor #798

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Jan 15, 2021

What does this PR do?

Add a workspace storage volume mount for che-theia editor. The GitHub authentication session is saved in this directory, so the GitHub authentication will be restored after workspace restart.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#18664

How to test this PR?

Open the che-theia's editor meta.yaml (< plugin registry url >/v3/plugins/eclipse/che-theia/next/) and see the workspace storage volume mount:

      volumes:
        - name: plugins
          mountPath: /plugins
        - name: workspaceStorage
          mountPath: /home/theia/.theia/workspace-storage

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Copy link
Contributor

@ericwill ericwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to approve last week, LGTM

@sunix
Copy link
Contributor

sunix commented Jan 19, 2021

@vinokurig so the referenced issue is not the right one in description

@vinokurig
Copy link
Contributor Author

@sunix, yes, I reopened the mistakenly closed issue and closed the right one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github pr plugin: fork creation is hanging when creating a pull request
4 participants