Add a PR check to ensure that sidecar executable files have executable permissions #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issions If a sidecar adds any .sh files, check that they are executable to prevent entrypoint errors. Fixes eclipse-che/che#18737 Signed-off-by: Eric Williams <ericwill@redhat.com>
ericwill
requested review from
benoitf,
sunix,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
|
@benoitf any thoughts? |
benoitf
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Williams ericwill@redhat.com
What does this PR do?
If a sidecar adds any .sh files, check that they are executable to prevent entrypoint errors.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Fixes eclipse-che/che#18737
How to test this PR?
Locally, add a non-executable .sh file in
sidecars/*and run.ci/sidecar-check-script-permissions.sh. The script should fail until the file gets executable permissions.PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.