Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

fix: Apply hack to allow to use ctrl-p on terminal #1201

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mtsmfm
Copy link
Contributor

@mtsmfm mtsmfm commented Aug 22, 2021

What does this PR do?

Currently, ctrl-p on terminal doesn't work because ctrl-p ctrl-q is docker's default detach keys and there's no way to customize it with k8s api.

kubernetes/kubectl#1011

Screenshot/screencast of this PR

before

before

after

after

What issues does this PR fix or reference?

How to test this PR?

  • The test platform: docker-desktop
  • Installation method: chectl
  • steps to reproduce
    • open terminal
    • runecho hi
    • type ctrl-p

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

@che-bot
Copy link
Contributor

che-bot commented Aug 22, 2021

Can one of the admins verify this patch?

@mtsmfm mtsmfm changed the title Apply hack to allow to use ctrl-p on terminal fix: Apply hack to allow to use ctrl-p on terminal Aug 22, 2021
@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #1201 (2ba01cf) into main (c299f59) will decrease coverage by 0.17%.
The diff coverage is 18.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1201      +/-   ##
==========================================
- Coverage   32.78%   32.60%   -0.18%     
==========================================
  Files         290      295       +5     
  Lines        9885     9997     +112     
  Branches     1457     1536      +79     
==========================================
+ Hits         3241     3260      +19     
+ Misses       6641     6628      -13     
- Partials        3      109     +106     
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts 0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts 0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts 0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts 0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts 0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts 0.00% <0.00%> (ø)
...he-server/src/node/che-server-http-service-impl.ts 0.00% <0.00%> (ø)
...-che-server/src/node/che-server-remote-api-impl.ts 38.88% <0.00%> (ø)
...browser/contribution/exec-terminal-contribution.ts 0.00% <0.00%> (ø)
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc9aed...2ba01cf. Read the comment docs.

@azatsarynnyy
Copy link
Member

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Aug 30, 2021

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1201
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1201

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@vitaliy-guliy
Copy link
Contributor

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2021

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1201
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1201

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@mtsmfm
Copy link
Contributor Author

mtsmfm commented Sep 4, 2021

@vitaliy-guliy
Copy link
Contributor

@mtsmfm please update your branch the first. che-theia/main has important updates, which allows happy path tests to be passed.

@mtsmfm
Copy link
Contributor Author

mtsmfm commented Sep 7, 2021

@vitaliy-guliy Rebased and force pushed.

@azatsarynnyy
Copy link
Member

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Sep 8, 2021

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1201
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1201

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@azatsarynnyy
Copy link
Member

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Sep 8, 2021

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1201
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1201

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@azatsarynnyy
Copy link
Member

For some reason, the images for running HappyPath tests aren't built.
@dmytro-ndp could you please take a look?

@dmytro-ndp
Copy link
Contributor

@azatsarynnyy: you need to add comment with [crw-ci-test --rebuild] to build theia images from PR

@dmytro-ndp
Copy link
Contributor

[crw-ci-test --rebuild]

@che-bot
Copy link
Contributor

che-bot commented Sep 9, 2021

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1201
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1201

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to test how it solves the problem on docker-desktop. If someone can - please do.
At least, I've checked that the patch doesn't break anything by testing it on DevSandbox.

@mtsmfm
Copy link
Contributor Author

mtsmfm commented Sep 27, 2021

I've found \u0000 is handle by zsh...
I'll change status to draft.

@mtsmfm mtsmfm marked this pull request as draft September 27, 2021 12:31
@azatsarynnyy azatsarynnyy self-requested a review October 19, 2021 17:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants