Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Fix git clone on page refresh #337

Closed
wants to merge 1 commit into from
Closed

Fix git clone on page refresh #337

wants to merge 1 commit into from

Conversation

vinokurig
Copy link
Contributor

Signed-off-by: Igor Vinokur ivinokur@redhat.com

What does this PR do?

Updates dependency to vscode git extension binary to fix the problem with cloning projects every time a workspace is loaded/refreshed, even if the project was already cloned

What issues does this PR fix or reference?

closes eclipse-che/che#13796

Release Notes

Docs PR

@vinokurig vinokurig changed the title Che 13769 7.0.0 Fix git clone on page refresh Jul 9, 2019
@sunix
Copy link
Contributor

sunix commented Jul 9, 2019

@vinokurig could you add the changeset of your fork at least so we know what you have changed ?

@vinokurig
Copy link
Contributor Author

@sunix

could you add the changeset of your fork at least so we know what you have changed ?

che-incubator/vscode-git@037f3e4

@sparkoo
Copy link
Member

sparkoo commented Jul 10, 2019

this PR currently blocks this one eclipse-che/che-devfile-registry#18 and it's related issue eclipse-che/che#13529

@sunix
Copy link
Contributor

sunix commented Jul 10, 2019

@vinokurig,
so ...

  • you fork,
  • you force push on master of that fork,
  • you don't create PR on the fork.

I really don't know how I can approve that ... what do we do ?

@vinokurig
Copy link
Contributor Author

@sunix the PR to git extension: che-incubator/vscode-git#2

@sunix
Copy link
Contributor

sunix commented Jul 11, 2019

so should we close that one ?

@sparkoo
Copy link
Member

sparkoo commented Jul 15, 2019

yes, I guess we can close this. Issue was fixed by #339 and #344

@vinokurig vinokurig closed this Jul 15, 2019
@vinokurig vinokurig deleted the che-13769_7.0.0 branch September 5, 2019 09:48
vinokurig pushed a commit that referenced this pull request Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants