Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Update go version to 1.12.9 #443

Merged
merged 5 commits into from
Oct 3, 2019
Merged

Update go version to 1.12.9 #443

merged 5 commits into from
Oct 3, 2019

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Sep 19, 2019

What does this PR do?

It updates go version to 1.12.9.

What issues does this PR fix or reference?

eclipse-che/che#13803

Related PRs

eclipse-che/che-devfile-registry#96
eclipse-che/che-plugin-registry#224

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@tolusha tolusha self-assigned this Sep 19, 2019
@che-bot
Copy link
Contributor

che-bot commented Sep 19, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@tolusha
Copy link
Contributor Author

tolusha commented Sep 25, 2019

@benoitf
Could you validate the PR pls?

@amisevsk
I am wondering if we have to keep original dockerfiles/remote-plugin-go-1.10.7 ?

@amisevsk
Copy link

I am wondering if we have to keep original dockerfiles/remote-plugin-go-1.10.7 ?

I'm not sure the policy on the che-theia side, but it's worth noting that we should go through a deprecation procedure for images in general. We can stop building the image but it should remain available for workspaces that were created using it.

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@tolusha
Copy link
Contributor Author

tolusha commented Sep 26, 2019

@amisevsk
Just added dockerfile for go 1.12.9 and excluded from the build dockerfile with go 1.10.7

@che-bot
Copy link
Contributor

che-bot commented Sep 26, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't be safer to just add new version and keep older for a while and deprecate it

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Sep 27, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Oct 3, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@tolusha tolusha merged commit 817d476 into master Oct 3, 2019
@tolusha tolusha deleted the ab/go branch October 3, 2019 09:02
vinokurig pushed a commit that referenced this pull request Apr 6, 2021
Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants