Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Revert 67f85f761cccf47d555a2cf1b82fd121f3530894 to fix a build #620

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

azatsarynnyy
Copy link
Member

@azatsarynnyy azatsarynnyy commented Feb 4, 2020

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

What does this PR do?

Reverts the commit 67f85f7 that breaks the build of Che Theia.

What issues does this PR fix or reference?

eclipse-che/che#15917

Release Notes

Docs PR

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may not revert the part in cico_common.sh but I'm fine

@azatsarynnyy
Copy link
Member Author

I'm merging it w/o waiting for the result of pr-checks since the changes in sh files fix the CI build. It doesn't affect the build and e2e tests.

@azatsarynnyy azatsarynnyy merged commit 5c71ecc into master Feb 4, 2020
@azatsarynnyy azatsarynnyy deleted the fix_build branch February 4, 2020 13:16
@che-bot
Copy link
Contributor

che-bot commented Feb 4, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:620
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:620

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Feb 4, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:620
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:620

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

vinokurig pushed a commit that referenced this pull request Apr 6, 2021
* Use yarn workspaces and improve icons-extensions-404 PR check

* Use yarn workspaces as we have multiple JS projects now
* Improve the icons/extensions 404 check to use HEAD requests

Fixes eclipse-che/che#17838

Signed-off-by: Eric Williams <ericwill@redhat.com>

* Add monorepo, consolidate deps, move PR check to /tools

Signed-off-by: Eric Williams <ericwill@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants