Prevents displaying installers with empty names and descriptions (#8536)

eclipse-che · Feb 1, 2018 · 4d96bca · 4d96bca
1 parent e5a9932
commit 4d96bca
Showing 1 changed file with 34 additions and 3 deletions.
diff --git a/.../src/main/java/org/eclipse/che/ide/processes/loading/WorkspaceLoadingTrackerViewImpl.java b/.../src/main/java/org/eclipse/che/ide/processes/loading/WorkspaceLoadingTrackerViewImpl.java
@@ -86,6 +86,12 @@ private class Installer {
     // Row containing error message
     Element errorSection;
 
+    /**
+     * Creates installer section.
+     *
+     * @param installerName installer name
+     * @param installerDescription installer description
+     */
     public Installer(String installerName, String installerDescription) {
       // Clone installerTemplate node
       section = installerTemplate.cloneNode(true).cast();
@@ -121,6 +127,25 @@ public Installer(String installerName, String installerDescription) {
       description.setInnerText(installerDescription);
     }
 
+    /**
+     * Sets installer name.
+     *
+     * @param installerName installer name
+     */
+    void setName(String installerName) {
+      name.setInnerText(installerName);
+    }
+
+    /**
+     * Sets installer description.
+     *
+     * @param installerDescription installer description
+     */
+    void setDescription(String installerDescription) {
+      description.setInnerText(installerDescription);
+    }
+
+    /** Changes installer state to STARTING. */
     void setStarting() {
       state.setAttribute("rel", "starting");
       state.setInnerText("Starting");
@@ -131,6 +156,7 @@ void setStarting() {
       animatedElements.add(status);
     }
 
+    /** Changes installer state to RUNNING. */
     void setRunning() {
       state.setAttribute("rel", "running");
       state.setInnerText("Running");
@@ -141,6 +167,7 @@ void setRunning() {
       animatedElements.remove(status);
     }
 
+    /** Changes installer state to STOPPED. */
     void setStopped() {
       state.setAttribute("rel", "stopped");
       state.setInnerText("Stopped");
@@ -186,6 +213,7 @@ void setFailed(String errorMessage) {
       tableBody.insertAfter(errorSection, section);
     }
 
+    /** Resets installer state. */
     void reset() {
       state.setAttribute("rel", "");
       state.setInnerText("");
@@ -325,12 +353,15 @@ void setState(String newState) {
      * @param installerDescription installer description
      */
     void addInstaller(String installerId, String installerName, String installerDescription) {
-      if (installers.containsKey(installerId)) {
+      Installer installer = installers.get(installerId);
+
+      if (installer != null) {
+        installer.setName(installerName);
+        installer.setDescription(installerDescription);
         return;
       }
 
-      Installer installer = new Installer(installerName, installerDescription);
-
+      installer = new Installer(installerName, installerDescription);
       installers.put(installerId, installer);
 
       tableBody.insertBefore(installer.section, machinesDelimiter);