Improves debug panel, fixes UI of configure breakpoints popup (#8520)

eclipse-che · Jan 30, 2018 · 6e8dae7 · 6e8dae7
1 parent db3c0b7
commit 6e8dae7
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 10 deletions.
diff --git a/...ebugger-ide/src/main/java/org/eclipse/che/plugin/debugger/ide/debug/DebuggerViewImpl.java b/...ebugger-ide/src/main/java/org/eclipse/che/plugin/debugger/ide/debug/DebuggerViewImpl.java
@@ -339,7 +339,7 @@ void onThreadChanged(ChangeEvent event) {
 
   private SimpleList<ActiveBreakpointWrapper> createBreakpointList() {
     TableElement breakPointsElement = Elements.createTableElement();
-    breakPointsElement.setAttribute("style", "width: 100%");
+    breakPointsElement.setAttribute("style", "width: 100%; border: none;");
 
     SimpleList.ListEventDelegate<ActiveBreakpointWrapper> breakpointListEventDelegate =
         new SimpleList.ListEventDelegate<ActiveBreakpointWrapper>() {
@@ -369,7 +369,7 @@ public void onListItemDoubleClicked(
 
   private SimpleList<StackFrameDump> createFramesList() {
     TableElement frameElement = Elements.createTableElement();
-    frameElement.setAttribute("style", "width: 100%");
+    frameElement.setAttribute("style", "width: 100%; border: none;");
 
     SimpleList.ListEventDelegate<StackFrameDump> frameListEventDelegate =
         new SimpleList.ListEventDelegate<StackFrameDump>() {

diff --git a/...ugger-ide/src/main/java/org/eclipse/che/plugin/debugger/ide/debug/DebuggerViewImpl.ui.xml b/...ugger-ide/src/main/java/org/eclipse/che/plugin/debugger/ide/debug/DebuggerViewImpl.ui.xml
@@ -16,7 +16,8 @@
              xmlns:g='urn:import:com.google.gwt.user.client.ui'>
     <ui:with field='locale' type='org.eclipse.che.plugin.debugger.ide.DebuggerLocalizationConstant'/>
     <ui:with field='coreRes' type='org.eclipse.che.ide.Resources'/>
-    <ui:style>
+
+    <ui:style src="org/eclipse/che/ide/api/ui/style.css">
         .executionPoint {
             font-weight: bold;
         }
@@ -50,7 +51,12 @@
             height: 100%;
             width: 100%;
         }
+
+        .list {
+            background: textFieldBackgroundColor;
+        }
     </ui:style>
+
     <g:DockLayoutPanel unit="PX" width="100%" height="100%">
         <g:north size="26.0">
             <g:FlowPanel width="100%" height="100%" debugId="debugger-upper-panel">
@@ -69,7 +75,7 @@
                                 <g:Label text="{locale.breakpoints}" addStyleNames="{style.alignLeft}"/>
                             </g:north>
                             <g:center>
-                                <g:ScrollPanel ui:field="breakpointsPanel" addStyleNames="{coreRes.coreCss.simpleListContainer}"
+                                <g:ScrollPanel ui:field="breakpointsPanel" addStyleNames="{style.list} {coreRes.coreCss.simpleListContainer}"
                                                debugId="debugger-breakpointsPanel"/>
                             </g:center>
                         </g:DockLayoutPanel>
@@ -94,8 +100,8 @@
                                                  debugId="thread-not-suspended">
                                         <g:Label text="{locale.debuggerThreadNotSuspend}"/>
                                     </g:FlowPanel>
-                                    <g:ScrollPanel addStyleNames="{coreRes.coreCss.simpleListContainer}"
-                                                   debugId="debugger-frames-list" width="100%" ui:field="framesPanel"/>
+                                    <g:ScrollPanel addStyleNames="{style.list} {coreRes.coreCss.simpleListContainer}"
+                                                   debugId="debugger-frames-list" width="100%" height="100%" ui:field="framesPanel"/>
                                 </g:FlowPanel>
                             </g:center>
                         </g:DockLayoutPanel>
@@ -111,7 +117,7 @@
                                 <g:SimplePanel ui:field="watchExpressionPanel" debugId="watch-expression-panel"/>
                             </g:west>
                             <g:center>
-                                <tree:Tree ui:field="tree" addStyleNames="{coreRes.coreCss.simpleListContainer}"/>
+                                <tree:Tree ui:field="tree" addStyleNames="{style.list} {coreRes.coreCss.simpleListContainer}"/>
                             </g:center>
                         </g:DockLayoutPanel>
                     </g:FlowPanel>

diff --git a/...debugger-ide/src/main/java/org/eclipse/che/plugin/debugger/ide/debug/FrameItemRender.java b/...debugger-ide/src/main/java/org/eclipse/che/plugin/debugger/ide/debug/FrameItemRender.java
@@ -64,4 +64,9 @@ public void render(Element itemElement, StackFrameDump itemData) {
     label.setInnerHTML(sb.toSafeHtml().asString());
     itemElement.appendChild(label);
   }
+
+  @Override
+  public Element createElement() {
+    return Elements.createTRElement();
+  }
 }
diff --git a/...g/eclipse/che/plugin/debugger/ide/debug/breakpoint/BreakpointConfigurationViewImpl.ui.xml b/...g/eclipse/che/plugin/debugger/ide/debug/breakpoint/BreakpointConfigurationViewImpl.ui.xml
@@ -18,7 +18,7 @@
     <ui:style>
         .condition {
             margin-left: 5px;
-            width: 310px;
+            width: 300px;
         }
 
         .hitCount {

diff --git a/...c/main/resources/org/eclipse/che/plugin/debugger/ide/configuration/editConfigurations.css b/...c/main/resources/org/eclipse/che/plugin/debugger/ide/configuration/editConfigurations.css
@@ -121,4 +121,4 @@ input.filterPlaceholder::-moz-placeholder {
     background-repeat: no-repeat;
     background-position: literal("calc(50% - 25px)") center;
     background-size: contain;
-}
+}
diff --git a/...lugin-debugger-ide/src/main/resources/org/eclipse/che/plugin/debugger/ide/debug/Debug.css b/...lugin-debugger-ide/src/main/resources/org/eclipse/che/plugin/debugger/ide/debug/Debug.css
@@ -18,4 +18,4 @@
     display: inline-block;
     text-decoration: none;
     padding: 0px 3px 0px 3px;
-}
+}