Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuration of syntax highlighting #1178

Closed
svenefftinge opened this issue May 4, 2016 · 3 comments · Fixed by #1392
Closed

Allow configuration of syntax highlighting #1178

svenefftinge opened this issue May 4, 2016 · 3 comments · Fixed by #1392
Labels
kind/enhancement A feature request - must adhere to the feature request template. kind/question Questions that haven't been identified as being feature requests or bugs.

Comments

@svenefftinge
Copy link
Contributor

We need a way to configure orion with syntax highlighting for additional mime types.
Currently it seems like the way is to patch embeddedToolingPlugin.js, which is inconvenient.
@svenefftinge
Copy link
Contributor Author

I think it would be good to add a method to org.eclipse.che.ide.editor.orion.client.jso.OrionCodeEditWidgetOverlay which allows to access the serviceRegistry.

@ghost ghost added kind/enhancement A feature request - must adhere to the feature request template. kind/question Questions that haven't been identified as being feature requests or bugs. labels May 5, 2016
@ashumilova
Copy link
Contributor

If you need Che support additional highlighting (supported by Orion) - you can register it here by file extension.
If you need to add new content type to Orion, then we can create an issue to provide access to services like "orion.core.contenttype" one.

@svenefftinge
Copy link
Contributor Author

I would like to add not-yet-supported highlighting. The hook you reference only let me associate file extensions with mime types, what I was asking is to add a new mime-type together with an orion highlighting service.

svenefftinge added a commit to TypeFox/che that referenced this issue May 31, 2016
@svenefftinge
[Issue eclipse-che#1178] Added hooks to register content type and hig…
f28a2bb 
…hlighting configuration for Orion editor.

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
@svenefftinge svenefftinge mentioned this issue May 31, 2016
Merged
svenefftinge added a commit to TypeFox/che that referenced this issue May 31, 2016
@svenefftinge
[Issue eclipse-che#1178] Added hooks to register content type and hig…
d4b4b27 
…hlighting configuration for Orion editor.

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
svenefftinge added a commit to TypeFox/che that referenced this issue May 31, 2016
@svenefftinge
[eclipse-che#1178] added some javadoc
02999c8
vparfonov pushed a commit that referenced this issue Jun 2, 2016
@svenefftinge
[Issue #1178] Added hook to register content type and highlighting in…
d6a79e7 
… orion (#1392)

* [Issue #1178] Added hooks to register content type and highlighting configuration for Orion editor.
* [#1178] added some javadoc

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
akurinnoy pushed a commit that referenced this issue Jun 6, 2016
@svenefftinge
[Issue #1178] Added hook to register content type and highlighting in…
b8fcd78 
… orion (#1392)

* [Issue #1178] Added hooks to register content type and highlighting configuration for Orion editor.
* [#1178] added some javadoc

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template. kind/question Questions that haven't been identified as being feature requests or bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Issue #1178] Added hook to register content type and highlighting in orion TypeFox/che
2 participants
@svenefftinge @ashumilova