Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a DSL to Theia (Extending Theia on Eclipse Che) and a Question Regarding the Reason for Che to add Theia #12011

Closed
SharkJ opened this issue Nov 21, 2018 · 14 comments
Labels
kind/question Questions that haven't been identified as being feature requests or bugs.

Comments

@SharkJ
Copy link

SharkJ commented Nov 21, 2018

Hi,

I'm trying to build a language extension for Theia on Eclipse Che (since Che does not allow syntax colouring). I have, so far, been able to add a language extension (DSL built using Xtext) with editor support in to the Theia IDE. I'm currently having several issues running it locally, so I'm using Gitpod for development.
Could you please tell me how I should implement a new language extension to Theia which is running on Eclipse Che? Is it support yet?
Another question I have is, why introduce Theia when you already have the Orion Editor? Is Che intending to shift completely to Theia in future? Will Orion no longer be supported then?

Thank You!

@skabashnyuk
Copy link
Contributor

@tsmaeder can you take a look?

@skabashnyuk skabashnyuk added the kind/question Questions that haven't been identified as being feature requests or bugs. label Nov 26, 2018
@SharkJ
Copy link
Author

SharkJ commented Nov 30, 2018

Can someone please tell me how I can add a new DSL to Theia in Che? I would really appreciate it if I could get some help.

@tsmaeder
Copy link
Contributor

@skabashnyuk I don't know. @benoitf ? @evidolob ?

@skabashnyuk
Copy link
Contributor

@SharkJ

  1. What is the difference between this issue and Regarding the Procedure used to Implement Syntax Highlighting Support to Eclipse Che for Existing Programming Languages (Java, Python, Ceylon etc.) #12038
  2. AFAIK our major direction of new languages support is LSP https://microsoft.github.io/language-server-protocol/. Can you take a look at https://github.com/svenefftinge/xtext-lsp-workshop so we rephrase this issue to something like : How to integrate my LSP based on xtext DSL into Eclipse Che (Theia or Gwt based)

@SharkJ
Copy link
Author

SharkJ commented Dec 3, 2018

@skabashnyuk Thanks for the reply!
I have already followed the links you have provided and have understood the method of implementing a xtext DSL to Che. My question here is how I should implement the DSL to ### Theia in ### Eclipse Che. i.e, the proper way to make changes to che/dockerfiles/theia. There is no clear guide on this currently.

The difference between #12038 and this issue is that I'm requesting a general method to implement language support in-built to che in #12038. I have mentioned clearly that I'm not asking a method related to Theia in issue #12038.
In this issue (#12011), I'm asking a way to add a language extension to che-theia.

Could you please let me know or direct me to a source of guidance on how to implement an extension to che-theia? AFAIK, LSP does not support syntax highlighting. That is the main reason I decided to move on to Theia.

@SharkJ
Copy link
Author

SharkJ commented Dec 3, 2018

@skabashnyuk There is this issue which I have raised in https://github.com/svenefftinge/xtext-lsp-workshop some time ago. According to @svenefftinge's reply, I need to configure the editor in order to provide syntax highlighting, since LSP does not support it.

@svenefftinge
Copy link
Contributor

If the language support targets Theia, you need to provide a Textmate grammar to have syntax coloring.
@benoitf can probably guide you about how to add it through a Theia plug-in so it can be used within Che 7.

@SharkJ
Copy link
Author

SharkJ commented Dec 3, 2018

Thank You @svenefftinge ! @benoitf Could you please guide me how to do this?

@l0rd
Copy link
Contributor

l0rd commented Dec 3, 2018

@SharkJ we are switching to Theia as default editor for Che. At the same time we are making editors configurable (i.e. you decide the editor when you start your workspace) and are moving the Orion adn GWT based editor to the new extensible editor model.

As mentioned by @svenefftinge Theia uses TextMate grammar to get syntax highlighting for your language (we already have some doc for this).

For autocomplete, go to definition etc...you need a LS in the form of a Theia Plugin. We do not have a tutorial for that yet, but we are actively working on it and you can reach us on mattermost or on our mailing list (che-dev@eclipse.org) to get help.

@SharkJ
Copy link
Author

SharkJ commented Dec 5, 2018

Hi @l0rd , Thanks for the reply! I referred the Theia docs and can create extensions for theia. However, my problem is how to implement an extension to che-theia. Can you please help me on that?

@l0rd
Copy link
Contributor

l0rd commented Dec 5, 2018

@SharkJ that's all we have now http://bit.ly/che-eclipsecon

@SharkJ
Copy link
Author

SharkJ commented Dec 6, 2018

Thank you very much @l0rd ! I will go through the document.

@SharkJ
Copy link
Author

SharkJ commented Jan 16, 2019

Hi,
Is there any way to add syntax highlighting support for a new DSL implemented in Eclipse Che by extending the Orion Editor?

@gorkem
Copy link
Contributor

gorkem commented Aug 23, 2019

Closing due to inactivity, please reopen if needed.

@gorkem gorkem closed this as completed Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Questions that haven't been identified as being feature requests or bugs.
Projects
None yet
Development

No branches or pull requests

6 participants