Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix license headers in ommisharp plugin #14224

Closed
tsmaeder opened this issue Aug 14, 2019 · 1 comment
Closed

Fix license headers in ommisharp plugin #14224

tsmaeder opened this issue Aug 14, 2019 · 1 comment
Labels
area/languages Issues related to Language extensions or plugins integration. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@tsmaeder
Copy link
Contributor

https://github.com/redhat-developer/omnisharp-theia-plugin contains a bunch of files that are copied from Microsofts VS Code C# plugin.

While we keep the original copyright header there are a couple of things we should clear up:

  1. At least, we need to add the file "license.txt" that the Microsoft header is pointing to
  2. Need to clarify if our standard EPL header is allowed here. It seems to imply that we are relicensing the whole file as EPL, which I'm not sure we can.
  3. We should probably point to the source of the code in the file headers
@tsmaeder tsmaeder added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Aug 14, 2019
@tsmaeder tsmaeder mentioned this issue Aug 14, 2019
Closed
24 tasks
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 14, 2019
@slemeur slemeur added this to the 7.1.0 milestone Aug 14, 2019
@slemeur slemeur added area/languages Issues related to Language extensions or plugins integration. team/languages and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 14, 2019
@tolusha tolusha mentioned this issue Aug 22, 2019
Merged
@tsmaeder
Copy link
Contributor Author

According to @benoitf the way we do it here is the same as in Theia, where the process has been cleared with the Eclipse legal team. We can add "license.txt" whenever we want. Not a blocker.

@tsmaeder tsmaeder removed this from the 7.1.0 milestone Aug 29, 2019
@tsmaeder tsmaeder added the severity/P2 Has a minor but important impact to the usage or development of the system. label Aug 29, 2019
@svor svor mentioned this issue Sep 10, 2019
Merged
@svor svor closed this as completed Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/languages Issues related to Language extensions or plugins integration. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@svor @slemeur @tsmaeder @che-bot