Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theia hotkeys aren't handled when a WebView is in focus #15763

Closed
azatsarynnyy opened this issue Jan 21, 2020 · 3 comments
Closed

Theia hotkeys aren't handled when a WebView is in focus #15763

azatsarynnyy opened this issue Jan 21, 2020 · 3 comments
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@azatsarynnyy
Copy link
Member

azatsarynnyy commented Jan 21, 2020

Describe the bug

Theia hotkeys aren't handled when a WebView is in focus.
It may be related to the recent changes upstream eclipse-theia/theia#6465

Steps to reproduce

  1. Click on WebView with Eclipse Che Welcome page.
  2. Use F1, for example.

Google Chrome Help page is opened.

Expected behavior

Theia hotkey has to be handled properly - Command Palette should be opened.

@azatsarynnyy azatsarynnyy added kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. area/editor/theia Issues related to the che-theia IDE of Che labels Jan 21, 2020
@RomanNikitenko
Copy link
Member

RomanNikitenko commented Jan 21, 2020

Faced with the same issue.
My use case is: try to create a new terminal using the hotkey when Eclipse Che Welcome page is in focus.
Usually it's my first action when a workspace is started.

@azatsarynnyy azatsarynnyy mentioned this issue Feb 3, 2020
20 tasks
@azatsarynnyy azatsarynnyy mentioned this issue Feb 19, 2020
16 tasks
@vzhukovs vzhukovs self-assigned this Feb 20, 2020
@azatsarynnyy azatsarynnyy added the status/in-progress This issue has been taken by an engineer and is under active development. label Feb 21, 2020
@azatsarynnyy azatsarynnyy added this to the 7.10.0 milestone Feb 25, 2020
@RomanNikitenko RomanNikitenko removed the status/in-progress This issue has been taken by an engineer and is under active development. label Feb 26, 2020
@azatsarynnyy azatsarynnyy reopened this Mar 2, 2020
@azatsarynnyy azatsarynnyy added the status/in-progress This issue has been taken by an engineer and is under active development. label Mar 2, 2020
@azatsarynnyy azatsarynnyy mentioned this issue Mar 11, 2020
19 tasks
@azatsarynnyy azatsarynnyy modified the milestones: 7.10.0, 7.11.0 Mar 11, 2020
@azatsarynnyy azatsarynnyy modified the milestones: 7.11, 7.12 Apr 1, 2020
@azatsarynnyy
Copy link
Member Author

azatsarynnyy commented Apr 1, 2020

The current status:

@azatsarynnyy
Copy link
Member Author

fixed upstream

@vzhukovs vzhukovs removed the status/in-progress This issue has been taken by an engineer and is under active development. label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants