Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webview: fix user input #7233

Merged
merged 1 commit into from
Feb 27, 2020
Merged

webview: fix user input #7233

merged 1 commit into from
Feb 27, 2020

Conversation

vince-fugnitto
Copy link
Member

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

What it does

Fixes #7232

This commit reverts the breaking change of #7216 which meant that users would not be able to provide keyboard input any longer in a webview.

How to test

  1. use any webview which can require user input
    1.1 for my test I used gitlens (also added builtin-git, builtin-git-ui and removed @theia/git)
    1.2 opened the Gitlens: Welcome which required input
  2. input should now be accepted by users

Review checklist

Reminder for reviewers

Fixes #7232

This commit reverts the breaking change of #7216 which
meant that users would not be able to provide keyboard input any
longer in a webview.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@vzhukovs
Copy link
Contributor

@akosyakov maybe it would be better in future just to prevent reserved browser hotkeys, like CtrlCmd+P, CtrlCmd+O, F1, etc. WDYT?

@akosyakov
Copy link
Member

akosyakov commented Feb 27, 2020

@vzhukovskii Please file a Theia issue for your original issue, we could think how we can tackle it if we can at all. I would assume that webview has a priority and can install handlers for f1 as well. Also looking at the code we don't prevent any webviews actions. Could it be that your webview installing a handler which prevents an event propagation to the main window?

@vince-fugnitto vince-fugnitto merged commit fe417a8 into master Feb 27, 2020
@vince-fugnitto vince-fugnitto deleted the vf/GH-7232 branch February 27, 2020 13:22
@vzhukovs
Copy link
Contributor

vzhukovs commented Feb 27, 2020

@akosyakov here is the issue for that #7235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical critical bugs / problems webviews issues related to webviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vscode webview input tag cannot enter anything
3 participants