Prevent default handling for the browser reserved hotkeys inside webviews #7216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iews Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
vzhukovs
added
enhancement
vince-fugnitto
approved these changes
Feb 25, 2020
There was a problem hiding this comment.
I verified the pull-request using the coding-cat example. I was able to trigger the command palette and search using keybindings (something that was not possible when on master).
vince-fugnitto
approved these changes
Feb 25, 2020
There was a problem hiding this comment.
I verified the pull-request using the coding-cat example. I was able to trigger the command palette and search using keybindings (something that was not possible when on master).
azatsarynnyy
approved these changes
Feb 25, 2020
16 tasks
JesterOrNot
pushed a commit
to JesterOrNot/theia
that referenced
this pull request
Mar 12, 2020
Fixes eclipse-theia#7232 This commit reverts the breaking change of eclipse-theia#7216 which meant that users would not be able to provide keyboard input any longer in a webview. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This changes proposal prevents calling default browser hotkeys, such as
CtrlCmd+P,CtrlCmd+Oinside Web Views, when the last one is under focus.Related issue: eclipse-che/che#15763
State in master:
State with current changes:
Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com
How to test
Use sample extension https://github.com/microsoft/vscode-extension-samples/tree/master/webview-sample and try to call default browser hotkey.
Review checklist
Reminder for reviewers