Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically handle users with a name that is not compatible with k8s namespace name #17841

Closed
skabashnyuk opened this issue Sep 11, 2020 · 1 comment
Closed

Automatically handle users with a name that is not compatible with k8s namespace name #17841

skabashnyuk opened this issue Sep 11, 2020 · 1 comment
Assignees
@mshaposhnik
Labels
area/che-server kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
Che Platform team sprint #190
Milestone
7.20

Comments

@skabashnyuk
Copy link
Contributor

Is your task related to a problem? Please describe.

We would like to automatically handle usecase when users have a name that is not compatible with k8s namespace name
and che server is going to create namespace according to the patter - che.

Describe the solution you'd like

  1. Introduce a configuration variable that is set by default 'true' and explicitly telling that che server is allowed namespace creation.
    The negative value is will be handled in separate issues and it is about use case when the che admin is responsible for pre-creating namespaces for users.
  2. If during the process of workspace startup che server wants to create a k8s namespace we detected that name contains invalid characters or it is longer when needed we needed.
    • remove all invalid characters
    • shrink name to 56 symbols
    • add suffix - '-<6 random characters-or-digits>'
    • record this name to user preferences for later use.

Describe alternatives you've considered

admin is responsible for pre-creating namespaces for users.

Additional context

#15323
@skabashnyuk skabashnyuk added kind/task Internal things, technical debt, and to-do tasks to be performed. area/che-server team/platform labels Sep 11, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 11, 2020
This was referenced Sep 11, 2020
Closed
Closed
@vparfonov vparfonov added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 14, 2020
@skabashnyuk skabashnyuk added this to the 7.20 milestone Sep 17, 2020
@skabashnyuk skabashnyuk added this to To do in Che Platform team sprint #190 via automation Sep 17, 2020
@skabashnyuk skabashnyuk moved this from To do to In progress in Che Platform team sprint #190 Sep 17, 2020
@mshaposhnik mshaposhnik mentioned this issue Sep 30, 2020
Merged
9 tasks
@mshaposhnik
Copy link
Contributor

Merged in #17892

Che Platform team sprint #190 automation moved this from In progress to Done Oct 7, 2020
@sparkoo sparkoo mentioned this issue Oct 22, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mshaposhnik mshaposhnik

Labels
area/che-server kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
No open projects
Che Platform team sprint #190
  
Done
Milestone
7.20
Development

No branches or pull requests
4 participants
@skabashnyuk @vparfonov @mshaposhnik @che-bot