Add namespace name cleanup before applying #17892

mshaposhnik · 2020-09-17T07:13:36Z

What does this PR do?

Sometimes users may have names incompartible with K8S objects naming (simplest example is using email as a username),
so in that case user-defined namespace creation with names generated using templates like abc-<username> will fail.

This PR adds checks for symbols and length validity, sanitizes username if required, and stores it into user preferences for further usage.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

#17841

How to test this PR?

Configure Che to use <username> placeholder namespace template. Register user with name containing symbol(s) not allowed in kubernetes names. Log in with that user and start workspace. Namespace with sanitized name should be created.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java

...va/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/NamespaceNameValidator.java

che-bot · 2020-09-17T07:26:34Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17892

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

che-bot · 2020-09-18T06:12:48Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17892

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/NamespaceNameValidatorTest.java

...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java

...va/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/NamespaceNameValidator.java

...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java

...va/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/NamespaceNameValidator.java

che-bot · 2020-09-23T05:49:38Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17892

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

che-bot · 2020-09-23T07:02:48Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17892

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

che-bot · 2020-09-23T12:23:05Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17892

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/NamespaceNameValidatorTest.java

che-bot · 2020-09-30T07:49:43Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17892

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java

che-bot · 2020-09-30T09:34:26Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17892

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java

che-bot · 2020-09-30T11:13:36Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17892

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

che-bot · 2020-09-30T11:36:56Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17892

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

che-bot · 2020-09-30T11:46:06Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17892

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java

che-bot · 2020-09-30T13:26:31Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17892

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

che-bot · 2020-10-01T09:57:53Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17892

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

che-bot · 2020-10-01T13:33:08Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:17892

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

che-bot · 2020-10-02T11:35:17Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:17892

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Add namespace name cleanup

2992f15

mshaposhnik changed the title ~~Add namespace name cleanup иуащку фззднштп~~ Add namespace name cleanup before applying Sep 17, 2020

mshaposhnik commented Sep 17, 2020

View reviewed changes

...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java Show resolved Hide resolved

mshaposhnik commented Sep 17, 2020

View reviewed changes

...va/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/NamespaceNameValidator.java Outdated Show resolved Hide resolved

che-bot added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Sep 17, 2020

Normalizing fixups

7205402

sparkoo reviewed Sep 18, 2020

View reviewed changes

metlos reviewed Sep 18, 2020

View reviewed changes

...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java Show resolved Hide resolved

...va/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/NamespaceNameValidator.java Outdated Show resolved Hide resolved

sparkoo reviewed Sep 21, 2020

View reviewed changes

...va/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/NamespaceNameValidator.java Outdated Show resolved Hide resolved

Namespace validations fixups

8b76ade

mshaposhnik added 2 commits September 23, 2020 09:41

Fixup openshift

dacb652

Merge branch 'master' into namespace_name_

bdfef7f

Added tests

c1b74ab

metlos reviewed Sep 23, 2020

View reviewed changes

...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/NamespaceNameValidatorTest.java Outdated Show resolved Hide resolved

mshaposhnik added 2 commits September 23, 2020 21:45

Added tests

e2799e2

Test fixup

39e21ca

mshaposhnik marked this pull request as ready for review September 23, 2020 18:49

mshaposhnik requested review from amisevsk, ibuziuk, l0rd, nickboldt and sleshchenko as code owners September 23, 2020 18:49

mshaposhnik removed request for nickboldt and l0rd September 23, 2020 18:50

refactor template change validation

266b02c

sparkoo reviewed Sep 30, 2020

View reviewed changes

...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java Outdated Show resolved Hide resolved

Add some jdocs

fdd9c7b

sparkoo reviewed Sep 30, 2020

View reviewed changes

...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java Show resolved Hide resolved

Store template directly

1f3a5d1

refactoring methods

f7586a9

refactoring methods

9d81619

metlos reviewed Sep 30, 2020

View reviewed changes

refactoring methods

ffc18c6

Add javadoc note

2e6a988

Merge branch 'master' into namespace_name_

f581249

metlos approved these changes Oct 2, 2020

View reviewed changes

sparkoo approved these changes Oct 2, 2020

View reviewed changes

skabashnyuk approved these changes Oct 2, 2020

View reviewed changes

Code simplify

e63908f

mshaposhnik merged commit b399be7 into eclipse-che:master Oct 7, 2020

mshaposhnik deleted the namespace_name_ branch October 7, 2020 07:15

che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 7, 2020

che-bot added this to the 7.20 milestone Oct 7, 2020

mshaposhnik mentioned this pull request Oct 7, 2020

Automatically handle users with a name that is not compatible with k8s namespace name #17841

Closed

sparkoo mentioned this pull request Oct 22, 2020

Namespace normalization does not work with namespace.allow_user_defined=false #18178

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add namespace name cleanup before applying #17892

Add namespace name cleanup before applying #17892

mshaposhnik commented Sep 17, 2020 •

edited

Loading

che-bot commented Sep 17, 2020

che-bot commented Sep 18, 2020

che-bot commented Sep 23, 2020

che-bot commented Sep 23, 2020

che-bot commented Sep 23, 2020

che-bot commented Sep 30, 2020

che-bot commented Sep 30, 2020

che-bot commented Sep 30, 2020

che-bot commented Sep 30, 2020

che-bot commented Sep 30, 2020

che-bot commented Sep 30, 2020

che-bot commented Oct 1, 2020

che-bot commented Oct 1, 2020

che-bot commented Oct 2, 2020

Add namespace name cleanup before applying #17892

Add namespace name cleanup before applying #17892

Conversation

mshaposhnik commented Sep 17, 2020 • edited Loading

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

che-bot commented Sep 17, 2020

che-bot commented Sep 18, 2020

che-bot commented Sep 23, 2020

che-bot commented Sep 23, 2020

che-bot commented Sep 23, 2020

che-bot commented Sep 30, 2020

che-bot commented Sep 30, 2020

che-bot commented Sep 30, 2020

che-bot commented Sep 30, 2020

che-bot commented Sep 30, 2020

che-bot commented Sep 30, 2020

che-bot commented Oct 1, 2020

che-bot commented Oct 1, 2020

che-bot commented Oct 2, 2020

mshaposhnik commented Sep 17, 2020 •

edited

Loading