Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge DevWorkspace Che operator in Che operator #19145

Closed
4 tasks done
l0rd opened this issue Feb 25, 2021 · 6 comments
Closed
4 tasks done

Merge DevWorkspace Che operator in Che operator #19145

l0rd opened this issue Feb 25, 2021 · 6 comments
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@l0rd
Copy link
Contributor

l0rd commented Feb 25, 2021

Is your enhancement related to a problem? Please describe.

In the DevWorkspace configuration Che operator will install both DevWorkspace operator (issue) and DevWorkspace Che operator (issue). Those are currently 2 independent operators: they can be installed even without Che. But although it makes sense for DevWorkspaec operator, DevWorkspace Che is highly coupled to Che, it does only make sense when Che is deployed.

Describe the solution you'd like

DevWorkspace Che controller and CRDs should be included in Che operator.

Sub tasks

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Feb 25, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 25, 2021
@l0rd l0rd added engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Feb 25, 2021
@tolusha tolusha added this to the 7.28 milestone Feb 25, 2021
@tolusha tolusha mentioned this issue Feb 25, 2021
70 tasks
@tolusha
Copy link
Contributor

tolusha commented Mar 15, 2021

@metlos suggested to merge DevWorkspace Che operator codebase into a Che Operator
@l0rd WDYT?

@l0rd
Copy link
Contributor Author

l0rd commented Mar 15, 2021

@tolusha I am +1 for that

@nickboldt
Copy link
Contributor

I'm +1 too, especially if it can be prioritied for 7.28.0 (or 7.28.x backport).

@tolusha
Copy link
Contributor

tolusha commented Mar 26, 2021

@l0rd
We decided to split the task into 2 steps.
On first step [1] we run DWCO in a separate pod.
On the second [2] we merge codebase and run DWCO in the same pod.

[1] Run DWCO and CO in a single container but in different pods #19402
[2] Merge DWCO and CO in a single codebase #19408

/cc @sparkoo @metlos @skabashnyuk

@l0rd
Copy link
Contributor Author

l0rd commented Mar 26, 2021

@tolusha it makes sense

@tolusha
Copy link
Contributor

tolusha commented Mar 31, 2021

This issue is started to be an umbrella for sub-tasks.
I've removed it from the current sprint and added another one [1] which is possible to complete.

[1] #19402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

6 participants