Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[che-auth] default enable native auth on kubernetes with devworkspaces #20853

Closed
sparkoo opened this issue Dec 1, 2021 · 5 comments
Closed
Labels
area/chectl Issues related to chectl, the CLI of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@sparkoo
Copy link
Member

sparkoo commented Dec 1, 2021

Is your enhancement related to a problem? Please describe

Once native authentication is implemented on kubernetes, we should enable it by default when devworkspaces are enabled. This is last piece missing eclipse-che/che-operator#1185 but to enable native auth, one must pass CheCluster patch with nativeUserMode:true set.

Describe the solution you'd like

enable native auth by default on kubernetes when devworkspaces enabled

It is not as trivial as simply setting one property. We need to deploy Dex on minikube first, which is now triggered with the nativeUserMode in CheCluster patch. However for similar job on OpenShift, the logic to use native auth by default is in che-operator. But che-operator is not available in the moment we need to deploy Dex.

Describe alternatives you've considered

No response

Additional context

eclipse-che/che-operator#1185
#20635
epic: #19182

@sparkoo sparkoo added the kind/enhancement A feature request - must adhere to the feature request template. label Dec 1, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 1, 2021
@tolusha
Copy link
Contributor

tolusha commented Dec 1, 2021

Did I understand correctly that operator is supposed to deploy Dex once nativeUserMode is enabled?

@sparkoo
Copy link
Member Author

sparkoo commented Dec 1, 2021

Did I understand correctly that operator is supposed to deploy Dex once nativeUserMode is enabled?

The goal is to enable nativeUserMode without the need of any checluster patch when you deploy on minikube with devworkspaces and we need Dex for that.

I'm only saying that on openshift, we're doing this logic in che-operator. However, here with dex it is more complicated and it will probably have to be in chectl as well. You better know how and where to implement that.

@tolusha
Copy link
Contributor

tolusha commented Dec 1, 2021

I see. Then it is chectl task to create checluster with devworkspace: enable and it is relatively easy.

@tolusha
Copy link
Contributor

tolusha commented Dec 1, 2021

Should it be done before eclipse-che/che-operator#1185 is merged?

@sparkoo
Copy link
Member Author

sparkoo commented Dec 1, 2021

Should it be done before eclipse-che/che-operator#1185 is merged?

no. It must be done after because it would break default deployment without that patch

@tolusha tolusha mentioned this issue Dec 1, 2021
28 tasks
@tolusha tolusha added area/chectl Issues related to chectl, the CLI of Che sprint/current team/deploy severity/P1 Has a major impact to usage or development of the system. labels Dec 1, 2021
@tolusha tolusha modified the milestones: 7.40, 7.41 Dec 1, 2021
@l0rd l0rd removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 1, 2021
@tolusha tolusha closed this as completed Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chectl Issues related to chectl, the CLI of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants