Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable native user mode if devworkspace engine is enabled #1870

Merged
merged 4 commits into from
Dec 6, 2021
Merged

Conversation

tolusha
Copy link
Collaborator

@tolusha tolusha commented Dec 2, 2021

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

Enable native user mode if devworkspace engine is enabled

Screenshot/screencast of this PR

  ✔ Show important messages
    ✔ Eclipse Che 7.41.0-SNAPSHOT has been successfully deployed.
    ✔ Documentation             : https://www.eclipse.org/che/docs/
    ✔ -------------------------------------------------------------------------------
    ✔ Users Dashboard           : https://192.168.99.100.nip.io
    ✔ Admin user login          : "admin:admin". NOTE: must change after first login.
    ✔ -------------------------------------------------------------------------------
    ✔ Plug-in Registry          : https://192.168.99.100.nip.io/plugin-registry/v3/
    ✔ Devfile Registry          : https://192.168.99.100.nip.io/devfile-registry/
    ✔ -------------------------------------------------------------------------------
    ✔ Dex user credentials      : che@eclipse.org:admin
    ✔ Dex user credentials      : user1@che:password
    ✔ Dex user credentials      : user2@che:password
    ✔ Dex user credentials      : user3@che:password
    ✔ Dex user credentials      : user4@che:password
    ✔ Dex user credentials      : user5@che:password
    ✔ -------------------------------------------------------------------------------
Command server:deploy has completed successfully in 08:26.

What issues does this PR fix or reference?

eclipse-che/che#20853
eclipse-che/che#20779

How to test this PR?

./run server:deploy --platform minikube --workspace-engine dev-workspace

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@sparkoo
Copy link
Member

sparkoo commented Dec 2, 2021

I've tested with my che-operator image eclipse-che/che-operator#1185 and works fine.

One issue here is, we no longer need the warning prompt that there is privilege escalation (https://github.com/che-incubator/chectl/blob/main/src/commands/server/deploy.ts#L343). I've fixed that in previous PR (https://github.com/che-incubator/chectl/pull/1864/files#diff-0c92bfdc017a79faa86cda8534f6cd10e6aa230c187d56f76e01a3df5a065b41R342), but it's not working here. I guess you set the value after this check.

@sparkoo
Copy link
Member

sparkoo commented Dec 2, 2021

next we should consider to include here printing the credentials of precreated users, because people won't know how to login to Che, which is an issue when it is the default eclipse-che/che#20779

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Copy link
Collaborator Author

tolusha commented Dec 2, 2021

@sparkoo
Updated

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@sparkoo
Copy link
Member

sparkoo commented Dec 2, 2021

@sparkoo Updated

nice. I've tested that and works fine

@openshift-ci
Copy link

openshift-ci bot commented Dec 2, 2021

@tolusha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v7-chectl-e2e-olm-installer 481e721 link true /test v7-chectl-e2e-olm-installer
ci/prow/v7-chectl-e2e-operator-installer 481e721 link true /test v7-chectl-e2e-operator-installer

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Dec 3, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, sparkoo, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Dec 6, 2021
@tolusha tolusha merged commit 6455df3 into main Dec 6, 2021
@tolusha tolusha deleted the 20853 branch December 6, 2021 09:09
@che-bot che-bot added this to the 7.41 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants