-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable native user mode if devworkspace engine is enabled #1870
Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
I've tested with my che-operator image eclipse-che/che-operator#1185 and works fine. One issue here is, we no longer need the warning prompt that there is privilege escalation (https://github.com/che-incubator/chectl/blob/main/src/commands/server/deploy.ts#L343). I've fixed that in previous PR (https://github.com/che-incubator/chectl/pull/1864/files#diff-0c92bfdc017a79faa86cda8534f6cd10e6aa230c187d56f76e01a3df5a065b41R342), but it's not working here. I guess you set the value after this check. |
next we should consider to include here printing the credentials of precreated users, because people won't know how to login to Che, which is an issue when it is the default eclipse-che/che#20779 |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@sparkoo |
nice. I've tested that and works fine |
@tolusha: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, sparkoo, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
New changes are detected. LGTM label has been removed. |
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
Enable native user mode if devworkspace engine is enabled
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#20853
eclipse-che/che#20779
How to test this PR?
./run server:deploy --platform minikube --workspace-engine dev-workspace
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.