Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add devfile support in UD #13198

Merged
merged 1 commit into from
May 21, 2019
Merged

Add devfile support in UD #13198

merged 1 commit into from
May 21, 2019

Conversation

ashumilova
Copy link
Contributor

Signed-off-by: Anna Shumilova ashumilo@redhat.com

What does this PR do?

What issues does this PR fix or reference?

#13067

Release Notes

Docs PR

@ashumilova ashumilova added status/in-progress This issue has been taken by an engineer and is under active development. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Apr 22, 2019
@ashumilova ashumilova self-assigned this Apr 22, 2019
This was referenced Apr 22, 2019
Merged
Closed
Merged
@sleshchenko
Copy link
Member

The following changes should be applied after merging of this PR
https://github.com/eclipse/che/compare/master...sleshchenko:dropWsConfigStub?expand=1

@ashumilova
Copy link
Contributor Author

ci-build

@ashumilova
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented May 14, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13198
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented May 14, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13198
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@amisevsk amisevsk mentioned this pull request May 14, 2019
Closed
@ashumilova
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented May 15, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13198
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented May 16, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13198
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@ashumilova
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented May 16, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13198
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented May 17, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13198
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented May 17, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13198
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented May 17, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13198
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@ashumilova
Copy link
Contributor Author

Rebasing to master

@ashumilova ashumilova requested a review from akurinnoy May 20, 2019 07:39
@ashumilova ashumilova marked this pull request as ready for review May 20, 2019 07:42
olexii4
olexii4 approved these changes May 20, 2019
View reviewed changes
dashboard/src/app/workspaces/create-workspace/create-workspace.service.ts
@@ -196,6 +189,39 @@ export class CreateWorkspaceSvc {
});
}

/*createWorkspaceFromDevfile(workspaceDevfile: che.IWorkspaceDevfile, attributes: any): ng.IPromise<che.IWorkspace> {
const namespaceId = this.namespaceSelectorSvc.getNamespaceId(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need it in this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's for further workspace creation from devfile

@ashumilova
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented May 20, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13198
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@ashumilova
Add devfile support in UD
97c6460 
Signed-off-by: Anna Shumilova <ashumilo@redhat.com>
@ashumilova ashumilova removed the status/in-progress This issue has been taken by an engineer and is under active development. label May 21, 2019
@ashumilova
Copy link
Contributor Author

Pushed re-based and squashed commits.
New test failures are the cause of the PR https://github.com/eclipse/che/pull/13361/files.

@ashumilova ashumilova merged commit be3a56c into master May 21, 2019
@ashumilova ashumilova deleted the devfile_ud branch May 21, 2019 07:14
@sleshchenko sleshchenko mentioned this pull request May 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olexii4 olexii4 olexii4 approved these changes

@akurinnoy akurinnoy akurinnoy approved these changes

@benoitf benoitf Awaiting requested review from benoitf

Assignees

@ashumilova ashumilova

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ashumilova @sleshchenko @che-bot @SkorikSergey @dmytro-ndp @olexii4 @akurinnoy