Store github token in session storage, remove on logout #13947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashumilova
added
kind/bug
benoitf
approved these changes
Jul 22, 2019
| @@ -68,7 +68,8 @@ export class CheKeycloak { | |||
| } | |||
|
|
|||
| logout(): void { | |||
| window.sessionStorage.setItem('oidcDashboardRedirectUrl', location.href); | |||
| window.sessionStorage.removeItem('githubToken'); | |||
| window.sessionStorage.setItem('oidcDashboardRedirectUrl', location.href); | |||
Signed-off-by: Anna Shumilova <ashumilo@redhat.com>
ashumilova
force-pushed
the
fix_github_token
branch
from
b7ecb10
to
6a93765
Compare
|
ci-test |
akurinnoy
approved these changes
Jul 23, 2019
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anna Shumilova ashumilo@redhat.com
What does this PR do?
Avoids saving GitHub token in Local Storage, stores it in Session Storage instead + removes it on logout.
Token will be lost:
Token is not available on another opened tab, but on page refresh - it keeps stored.
What issues does this PR fix or reference?
#13694