Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of non-working workaround to flakiness when Java LS server initialization failed #14945

Merged
merged 5 commits into from
Oct 22, 2019
Merged

Get rid of non-working workaround to flakiness when Java LS server initialization failed #14945

merged 5 commits into from
Oct 22, 2019

Conversation

dmytro-ndp
Copy link
Contributor

@dmytro-ndp dmytro-ndp commented Oct 21, 2019 •
edited
Loading

What does this PR do?

It logs usage of workaround to failed check of LS server language initialization in E2E Happy path tests.

Update: it seems existed workaround doesn't work, and has just hidden failure details .
So, that workaround has been removed https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/che-pr-tests/view/K8S/job/Single-Che-PR-check-E2E-Happy-path-tests-against-k8s-on-codenvy-slave9/862/console:

        ▼ Ide.waitStatusBarContains "Starting Java Language Server"
Known flakiness https://github.com/eclipse/che/issues/14944
    1) Java LS initialization


  3 passing (2m)
  1 failing

  1) Language server validation
       Java LS initialization:
     TimeoutError: Wait timed out after 21008ms

What issues does this PR fix or reference?

#14944, #14283

@dmytro-ndp
Log workaround failed Java LS server initialization
6be77a3 
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Oct 21, 2019
@dmytro-ndp
Copy link
Contributor Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Oct 21, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@che-bot
Copy link
Contributor

che-bot commented Oct 21, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Oct 21, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@dmytro-ndp
Copy link
Contributor Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Oct 21, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@dmytro-ndp dmytro-ndp changed the title Log workaround failed Java LS server initialization Log workaround if Java LS server initialization failed Oct 21, 2019
@dmytro-ndp
Don't hide flakiness
c11b18b 
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@dmytro-ndp
Copy link
Contributor Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Oct 21, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@dmytro-ndp
Copy link
Contributor Author

crw-ci-test

2 similar comments
@dmytro-ndp
Copy link
Contributor Author

crw-ci-test

@dmytro-ndp
Copy link
Contributor Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Oct 21, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@che-bot
Copy link
Contributor

che-bot commented Oct 21, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@che-bot
Copy link
Contributor

che-bot commented Oct 21, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Oct 21, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@che-bot
Copy link
Contributor

che-bot commented Oct 21, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@dmytro-ndp dmytro-ndp changed the title Log workaround if Java LS server initialization failed Get rid of non-working workaround to flakiness when Java LS server initialization failed Oct 22, 2019
@dmytro-ndp
Fix workaround
789f862 
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@dmytro-ndp
Copy link
Contributor Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Oct 22, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Oct 22, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@dmytro-ndp
Fix error
a27c360 
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@dmytro-ndp
Copy link
Contributor Author

crw-ci-test

1 similar comment
@dmytro-ndp
Copy link
Contributor Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Oct 22, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@che-bot
Copy link
Contributor

che-bot commented Oct 22, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@che-bot
Copy link
Contributor

che-bot commented Oct 22, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@che-bot
Copy link
Contributor

che-bot commented Oct 22, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@dmytro-ndp
Set Log.debug() for DriverHelper methods with high impact
32ce70b 
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Oct 22, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Oct 22, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@dmytro-ndp
Copy link
Contributor Author

ci-build

1 similar comment
@dmytro-ndp
Copy link
Contributor Author

ci-build

@che-bot
Copy link
Contributor

che-bot commented Oct 22, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@dmytro-ndp dmytro-ndp merged commit 2629f8a into master Oct 22, 2019
dmytro-ndp added a commit that referenced this pull request Oct 29, 2019
@dmytro-ndp
Log and fix workaround to Java LS server initialization failure (#14945)
798562a 
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
dmytro-ndp added a commit that referenced this pull request Oct 29, 2019
@dmytro-ndp
7.3.x E2E happy path tests fixup (#15010)
12c5f01 
* Fix version of jar file in petclinic project of happy path tests (#14936)

* Log and fix workaround to Java LS server initialization failure (#14945)

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@dmytro-ndp dmytro-ndp deleted the che-14944-log-workaround branch October 31, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhopp rhopp rhopp approved these changes

@musienko-maxim musienko-maxim musienko-maxim approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmytro-ndp @che-bot @rhopp @musienko-maxim