Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UD] Use default icon if actual icon is not accessible #15181

Merged
merged 1 commit into from
Nov 14, 2019
Merged

[UD] Use default icon if actual icon is not accessible #15181

merged 1 commit into from
Nov 14, 2019

Conversation

akurinnoy
Copy link
Contributor

Signed-off-by: Oleksii Kurinnyi okurinny@redhat.com

What does this PR do?

If User Dashboard cannot access or retrieve a devfile icon then default icon will be shown.

What issues does this PR fix or reference?

fixes #15089

@akurinnoy akurinnoy self-assigned this Nov 13, 2019
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Nov 13, 2019
@che-bot
Copy link
Contributor

che-bot commented Nov 13, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@akurinnoy
Copy link
Contributor Author

crw-ci-test

@eclipse-che eclipse-che deleted a comment from che-bot Nov 13, 2019
@che-bot
Copy link
Contributor

che-bot commented Nov 13, 2019

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@SkorikSergey
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/2984//Selenium_20tests_20report/) doesn't show any regression against this Pull request.

@akurinnoy
use default icon if actual icon is not accessible
76bd7ed 
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy
Copy link
Contributor Author

PR has been rebased to resolve merge conflicts

@che-bot
Copy link
Contributor

che-bot commented Nov 13, 2019

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Nov 13, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@akurinnoy akurinnoy merged commit 837ce36 into master Nov 14, 2019
@akurinnoy akurinnoy deleted the show-default-icons branch November 14, 2019 12:29
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
@akurinnoy
use default icon if actual icon is not accessible (#15181)
145e7c4 
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@olexii4 olexii4 Awaiting requested review from olexii4

@ashumilova ashumilova Awaiting requested review from ashumilova

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

Assignees

@akurinnoy akurinnoy

Labels
kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard should use default icon for devfiles when actual icon is inaccessible
4 participants
@akurinnoy @che-bot @SkorikSergey @benoitf