Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UD] Use default icon if actual icon is not accessible #15195

Merged
merged 2 commits into from
Nov 14, 2019

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

If User Dashboard cannot access or retrieve a devfile icon then default icon will be shown.

This is cherry-pick of 837ce36

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@che-bot che-bot added target/branch Indicates that a PR will be merged into a branch other than master. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Nov 14, 2019
@che-bot
Copy link
Contributor

che-bot commented Nov 14, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@che-bot
Copy link
Contributor

che-bot commented Nov 14, 2019

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Nov 14, 2019

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Nov 14, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@akurinnoy akurinnoy merged commit d9694d4 into 7.3.x Nov 14, 2019
@akurinnoy akurinnoy deleted the 7.3.x-use-default-icons branch November 14, 2019 14:34
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants