Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

che #15182 Updating rh-che to the 7.3.2 upstream version #1696

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Nov 15, 2019

What does this PR do?

Updating rh-che to the 7.3.2 upstream version

What issues does this PR fix or reference?

eclipse-che/che#15182

How have you tested this PR?

PR-check CI

@centos-ci
Copy link
Collaborator

@ibuziuk
Copy link
Member Author

ibuziuk commented Nov 16, 2019

[test]

@centos-ci
Copy link
Collaborator

@ibuziuk
Copy link
Member Author

ibuziuk commented Nov 17, 2019

Looks like we do not need to backport any UD changes from - eclipse-che/che#15194, eclipse-che/che#15195

[ibuziuk@fedora rh-che]$ ./dev-scripts/check-upstream-dashboard.sh 7.3.2
Testing update to version 7.3.2
Getting dashboard source diff for current Che parent version
     [exec] Result: 1
Updating parent version in pom.xml to 7.3.2
Getting dashboard source diff for Che parent version 7.3.2
     [exec] Result: 1
No upstream changes detected.
Executing cleanup
  • ide-iframe.service.ts
  • ide.service.ts
  • che-workspace.factory.ts
  • devfile-selector.controller.ts
  • devfile-selector.html
  • img-src.directive.ts

are not overridden on rh-che side

@centos-ci
Copy link
Collaborator

@ibuziuk ibuziuk marked this pull request as ready for review November 17, 2019 09:00
@ibuziuk
Copy link
Member Author

ibuziuk commented Nov 17, 2019

@ScrewTSW looks like the PR check is still deploying 7.3.1 version of the registry - http://che-plugin-registry-prcheck-1696.devtools-dev.ext.devshift.net/v3/plugins/camel-tooling/vscode-apache-camel/0.0.14/ This currently breaks the test verification

@ScrewTSW
Copy link
Member

[test]

@ScrewTSW
Copy link
Member

ScrewTSW commented Nov 18, 2019

@ScrewTSW looks like the PR check is still deploying 7.3.1 version of the registry - http://che-plugin-registry-prcheck-1696.devtools-dev.ext.devshift.net/v3/plugins/camel-tooling/vscode-apache-camel/0.0.14/ This currently breaks the test verification

should be fixed with #1700

@centos-ci
Copy link
Collaborator

@amisevsk
Copy link
Collaborator

Testing update to version 7.3.2
Getting dashboard source diff for current Che parent version
     [exec] Result: 1
Updating parent version in pom.xml to 7.3.2
Getting dashboard source diff for Che parent version 7.3.2
     [exec] Result: 1
No upstream changes detected.
Executing cleanup

@ibuziuk
Copy link
Member Author

ibuziuk commented Nov 18, 2019

@amisevsk thanks for double-checking 👍

@ibuziuk ibuziuk merged commit 26725e9 into master Nov 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the ibuziuk-patch-27 branch November 18, 2019 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants