Ensure proxy settings are provisioned for init containers #15264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
requested review from
l0rd,
metlos,
nickboldt,
rhopp and
sleshchenko
as code owners
che-bot
added
status/code-review
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
sleshchenko
approved these changes
Nov 21, 2019
|
ci-build |
This was referenced Nov 21, 2019
nickboldt
pushed a commit
to redhat-developer/devspaces
that referenced
this pull request
Nov 22, 2019
* Apply patch to fix proxy issue from upstream Che during build Apply patch derived from eclipse-che/che#15264 to Che during build to workaround eclipse-che/che#15265 Signed-off-by: Angel Misevski <amisevsk@redhat.com> * fixup: typo Signed-off-by: Angel Misevski <amisevsk@redhat.com> * fixup: workaround groovy weirdness Signed-off-by: Angel Misevski <amisevsk@redhat.com> * fixup: continue to fight against groovy+sh Signed-off-by: Angel Misevski <amisevsk@redhat.com> * fixup: Stash patches in crw part, unstash to patch Che Signed-off-by: Angel Misevski <amisevsk@redhat.com>
metlos
approved these changes
Nov 22, 2019
|
ci-test |
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
|
@vparfonov @rhopp am I correct that PR check is expected to fail on the 7.3.x branch? |
ibuziuk
approved these changes
Dec 4, 2019
There was a problem hiding this comment.
I checked with @vparfonov and the e2e failures are expected. So, I believe we are good to mere
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cherry-pick of #15263