Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply patch to fix proxy issue from upstream Che during build #202

Merged
merged 5 commits into from
Nov 22, 2019
Merged

Apply patch to fix proxy issue from upstream Che during build #202

merged 5 commits into from
Nov 22, 2019

Conversation

amisevsk
Copy link
Contributor

Apply patch derived from eclipse-che/che#15264 to Che during build to workaround eclipse-che/che#15265 (CRW-494)

I can't test this change directly.

If merged, this PR makes #201 obsolete.

@amisevsk
Apply patch to fix proxy issue from upstream Che during build
c154cc7 
Apply patch derived from eclipse-che/che#15264
to Che during build to workaround eclipse-che/che#15265

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@devstudio-release
Copy link
Contributor

crw_stable-branch_PR # 162: FAILURE

@amisevsk
fixup: typo
240139b 
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@devstudio-release
Copy link
Contributor

crw_stable-branch_PR # 163: FAILURE

@amisevsk
fixup: workaround groovy weirdness
1ba1a3f 
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@devstudio-release
Copy link
Contributor

crw_stable-branch_PR # 164: FAILURE

@devstudio-release
Copy link
Contributor

crw_stable-branch_PR # 165: FAILURE

@nickboldt
Copy link
Member

testPR

@devstudio-release
Copy link
Contributor

crw_master_PR # 6: FAILURE

@amisevsk
fixup: continue to fight against groovy+sh
80074e0 
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
nickboldt
nickboldt reviewed Nov 21, 2019
View reviewed changes
Jenkinsfile Outdated Show resolved Hide resolved
@nickboldt nickboldt mentioned this pull request Nov 21, 2019
Closed
@devstudio-release
Copy link
Contributor

crw_master_PR # 7: FAILURE

@amisevsk
fixup: Stash patches in crw part, unstash to patch Che
94330bf 
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@devstudio-release
Copy link
Contributor

crw_master_PR # 10: SUCCESS

@nickboldt
Copy link
Member

testPR

@devstudio-release
Copy link
Contributor

crw_master_PR # 11: SUCCESS

@nickboldt
Copy link
Member

nickboldt commented Nov 22, 2019 •
edited
Loading

To test PR build 11: docker pull registry-proxy.engineering.redhat.com/rh-osbs/codeready-workspaces-server-rhel8:crw-2.0-rhel-8-containers-candidate-89319-20191122035915

@nickboldt
Copy link
Member

nickboldt commented Nov 22, 2019 •
edited
Loading

testPR (this is just to test a job config change for the way the build description is computed in https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/get-sources-rhpkg-container-build/2216/consoleFull -- no actual need to verify the PR build 12 bits -- the PR build 11 ones should be identical.)

@devstudio-release
Copy link
Contributor

crw_master_PR # 12: SUCCESS

@amisevsk
Copy link
Contributor Author

Tested the latest PR build on the cluster that was reproducing CRW-494 and was able to start a workspace. I'm 👍 to merge.

@rhopp
Copy link
Contributor

rhopp commented Nov 22, 2019

+1 for merging.
QE will get one day to verify final image and if something goes REALLY sideways, we should be able to revert&rebuild IMO.

@nickboldt nickboldt merged commit 520850c into redhat-developer:master Nov 22, 2019
@nickboldt
Copy link
Member

nickboldt commented Nov 22, 2019 •
edited
Loading

re: build description on crw_master_PR check job... it's not perfect but https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/get-sources-rhpkg-container-build/2218/ at least now parses out the container image and tag for the scratch build, so it's easier to test the output without CTRL-F and some guesswork. :D

calling it good enough for now but we can definitely iterate this to something better (eg., so the information appears in GH, not just in jenkins). #techdebt #helpMeQEFolksYoureMyOnlyHope

apupier pushed a commit to apupier/codeready-workspaces that referenced this pull request Oct 20, 2020
@SkorikSergey
[Selenium] Select identity provider from providers list (redhat-devel…
4d7573d 
…oper#161)

* check if identity providers list exists on login Openshif page

* add info about known redhat-developer#202 issue

* changes according to review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickboldt nickboldt nickboldt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amisevsk @devstudio-release @nickboldt @rhopp