Add HTTP Host header to support Docker v1.12 #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
| @@ -67,6 +67,7 @@ protected DockerResponse request(String method, String path, String query, List< | |||
| for (Pair<String, ?> header : headers) { | |||
| connection.setRequestProperty(header.first, String.valueOf(header.second)); | |||
| } | |||
| connection.setRequestProperty("Host", url.toString()); | |||
There was a problem hiding this comment.
In that case not only host will be put in that header but host + path +query.
@l0rd Do you think it is OK or only host+port should be put in that header.
There was a problem hiding this comment.
@garagatyi you are absolutely right. We should set it to host+port only. Although I've test it and it worked, path+query should not be there. I'll fix that.
There was a problem hiding this comment.
We still can use empty value. it is valid value due to the spec.
Signed-off-by: Mario Loriedo <mloriedo@redhat.com>
|
LGTM |
|
@skabashnyuk Please take a look |
|
ok |
|
LGTM |
|
OK |
tolusha
pushed a commit
that referenced
this pull request
Jul 5, 2016
Signed-off-by: Mario Loriedo <mloriedo@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hostis a mandatory header in HTTP 1.1 specifications. In previous versions of Docker that header wasn't required but release v1.12 use golang 1.6.2 that makes this header mandatory.Therefore Docker v1.12 daemon doesn't accept HTTP 1.1 requests with no
Hostheader set (you can find some references to the discussions here).This works:
echo -e "GET /containers/json HTTP/1.1\r\nHost: \r\n\r\n" | netcat -U /var/run/docker.sockThis doesn't work:
echo -e "GET /containers/json HTTP/1.1\r\n\r\n" | netcat -U /var/run/docker.sockAs a consequence in Che we had this nasty error message whenever we tried to create a new workspace:
This PR is related to #1482 and #745.