cleanup before workspace start #16498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Vala <mvala@redhat.com>
sparkoo
requested review from
amisevsk,
l0rd,
metlos,
nickboldt,
rhopp and
sleshchenko
as code owners
che-bot
added
status/code-review
Signed-off-by: Michal Vala <mvala@redhat.com>
sparkoo
changed the title
skabashnyuk
approved these changes
Apr 1, 2020
sleshchenko
approved these changes
Apr 1, 2020
sleshchenko
reviewed
Apr 1, 2020
| @@ -410,6 +410,7 @@ public void startsKubernetesEnvironment() throws Exception { | |||
| verify(services).create(any()); | |||
| verify(secrets).create(any()); | |||
| verify(configMaps).create(any()); | |||
| verify(namespace).cleanUp(); | |||
There was a problem hiding this comment.
I know, currently, the test does not respect the order but still, it would be better to put this call where it's expected to be called, somewhere before verify(deployments).deploy(any(Pod.class))
There was a problem hiding this comment.
I've added an extra test for this case, to not increase complexity of this one...
Signed-off-by: Michal Vala <mvala@redhat.com>
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
che-bot
removed
the
status/code-review
skabashnyuk
added a commit
to skabashnyuk/che
that referenced
this pull request
Apr 6, 2020
This reverts commit 983d0a5. Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michal Vala mvala@redhat.com
What does this PR do?
Cleanup workspace objects before start to avoid failures when creating.
What issues does this PR fix or reference?
#16418
Release Notes
Docs PR