Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds update profile form template with validation of username to be k8s DNS compatible #17780

Merged
merged 8 commits into from
Sep 8, 2020
Merged

Adds update profile form template with validation of username to be k8s DNS compatible #17780

merged 8 commits into from
Sep 8, 2020

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Sep 3, 2020 •
edited
Loading

What does this PR do?

  1. Adds update profile form template with validation of username to be k8s DNS compatible:
    1

  2. Adds a new theme che-username-edit-disabled based on che which put username filed to readonly. It doesn't allow to be accidentally autocompleted.
    2

What issues does this PR fix or reference?

#17265

@tolusha
Disable editing username on registration form
387f890 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Disable editing username on registration form
a567d96 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Disable editing username on registration form
df4489a 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Making the username editable withe the validation to make it k8s DNS …
cccf7b1 
…compatible

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Fixes
f1fc62f 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Fixes
1119bda 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Sep 3, 2020
This was referenced Sep 3, 2020
Closed
Closed
@che-bot
Copy link
Contributor

che-bot commented Sep 3, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@tolusha
Add theme to put username field to readonly
00219ab 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Copy link
Contributor Author

tolusha commented Sep 4, 2020

PR and description have been updated.

@tolusha
Copy link
Contributor Author

tolusha commented Sep 4, 2020

/cc @alexeykazakov

@che-bot
Copy link
Contributor

che-bot commented Sep 4, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@sunix
Copy link
Contributor

sunix commented Sep 7, 2020 •
edited
Loading

Community meeting proposal for new theme name: che-username-readonly ?

@l0rd
Copy link
Contributor

l0rd commented Sep 7, 2020

@tolusha how can an admin configure Che to use the che-username-edit-disabled theme?

@tolusha
Copy link
Contributor Author

tolusha commented Sep 8, 2020 •
edited
Loading

@sunix
the shorter - the better ;) I will change to che-username-readonly

@l0rd

  1. Login into keycloak admin console
  2. Select `Themes
  3. Select che-username-edit-disabled in the dropbox menu of the login theme.

@tolusha
Change theme title to che-username-readonly
0495dab 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Sep 8, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@tolusha
Copy link
Contributor Author

tolusha commented Sep 8, 2020

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Sep 8, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@tolusha tolusha merged commit 098bf02 into master Sep 8, 2020
@tolusha tolusha deleted the ab/cheusernameeditdisabledtheme branch September 8, 2020 13:39
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 8, 2020
@che-bot che-bot added this to the 7.19 milestone Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@benoitf benoitf Awaiting requested review from benoitf

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
7.19
Development

Successfully merging this pull request may close these issues.
5 participants
@tolusha @che-bot @sunix @l0rd @skabashnyuk